Skip to content

some small improvements to the data explorer webpage#341

Merged
nevrome merged 9 commits intomasterfrom
sortableHTMLTable
Apr 23, 2025
Merged

some small improvements to the data explorer webpage#341
nevrome merged 9 commits intomasterfrom
sortableHTMLTable

Conversation

@nevrome
Copy link
Copy Markdown
Member

@nevrome nevrome commented Apr 5, 2025

Motivated by a comment of @KathrinNaegele I did some work on the html API this weekend.

As suggested by @stschiff in #333, I ...

  • added per-archive lists of last-modified packages to the main page
  • added the last-modified dates for each package in the package table on the archive page
  • made the package and individual lists dynamic and sortable with a new dependency on simple-datatables (essentially DataTables without jQuery)

I haven't tested this yet with the Poseidon server production setup.

@nevrome nevrome requested a review from stschiff April 5, 2025 21:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 55.55%. Comparing base (d0c7b34) to head (3a58923).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/Poseidon/ServerHTML.hs 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   55.75%   55.55%   -0.20%     
==========================================
  Files          31       31              
  Lines        4744     4761      +17     
  Branches      510      510              
==========================================
  Hits         2645     2645              
- Misses       1589     1606      +17     
  Partials      510      510              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stschiff
Copy link
Copy Markdown
Member

stschiff commented Apr 8, 2025

Great, I'll take a look later, shouldn't take too long

Copy link
Copy Markdown
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I've quickly tested it locally. Seems to all work as expected. Thanks.

@stschiff
Copy link
Copy Markdown
Member

Note that CI fails. Note sure what exactly though.

@nevrome nevrome merged commit 0981bd7 into master Apr 23, 2025
2 of 4 checks passed
@nevrome nevrome deleted the sortableHTMLTable branch April 23, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants