fix: respect map.annotation string#307
Merged
RyanZim merged 4 commits intopostcss:masterfrom Jan 9, 2020
Merged
Conversation
618cb7d to
d7ac29d
Compare
RyanZim
reviewed
Jan 8, 2020
Collaborator
RyanZim
left a comment
There was a problem hiding this comment.
Code looks good to me.
There's a unit test for lib/mapFile.js here that needs fixing since the function signature changed:
Line 76 in 745ad2c
Also, an integration test using map.annotation would be great, although not required.
Contributor
Author
|
@RyanZim I've fixed up the unit tests to take the correct objects. I've also added an extra case to show what happens when Happy to add extra integration tests if you feel them necessary. Could you please point to where I might add them? |
Collaborator
|
Released in 7.1.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the PostCSS docs on sourcemaps the
opts.map.annotationoption can be set to a string, to write a manually named sourcemap file:This PR fixes PostCSS-cli to acknowledge this option, and refactors
getMapfileto returnopts.map.annotationif the option is set to a string.