Skip to content

Conditional compile Poison-related modules#98

Merged
ericmj merged 1 commit into
potatosalad:masterfrom
thiamsantos:ts-poison-conditional-compilation
Nov 22, 2020
Merged

Conditional compile Poison-related modules#98
ericmj merged 1 commit into
potatosalad:masterfrom
thiamsantos:ts-poison-conditional-compilation

Conversation

@thiamsantos

@thiamsantos thiamsantos commented Nov 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #81

Before:

==> jose
Compiling 106 files (.erl)
Compiling 8 files (.ex)
warning: Poison.EncodeError.exception/1 is undefined (module Poison.EncodeError is not available or is yet to be defined)
  lib/jose/poison/lexical_encoder.ex:8: JOSE.Poison.LexicalEncodeError.exception/1

Generated jose app

After:

==> jose
Compiling 2 files (.ex)

@thiamsantos thiamsantos mentioned this pull request Nov 21, 2020
Merged
@ericmj

ericmj commented Nov 22, 2020

Copy link
Copy Markdown
Collaborator

Thanks for this PR as well!

@ericmj ericmj merged commit 6a3f4e8 into potatosalad:master Nov 22, 2020
@lnikkila lnikkila mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clear warning on "Poison.EncodeError is not available"

2 participants

@thiamsantos @ericmj
⚡