Adding Hydrogen Data to the ChemKED-database folder#22
Adding Hydrogen Data to the ChemKED-database folder#22MariaPoliti wants to merge 3 commits intopr-omethe-us:masterfrom
Conversation
|
For ease of reference/comparison, here is the list of references included in this PR:
|
|
@bryanwweber what do you think about the directory structure for these files? I realize it doesn't matter that much, but as the database grows and we get (lots) more files for particular fuels, it would be good to establish a preferred convention. |
| pressure: | ||
| - 0.233 atm | ||
| composition: *comp | ||
| ignition-type: *ign No newline at end of file |
There was a problem hiding this comment.
Please make sure to add newlines to the end of each file
There was a problem hiding this comment.
Got it! I will modify the files to include the endline.
|
@kyleniemeyer I think a top-level fuel directory is fine, below that as you say it doesn't matter. I would just avoid characters such as Also, @MariaPoliti, the convention for YAML files is to have 2 spaces of indentation (in addition to my comment about newlines). I'll try to make some time in the next two weeks to review the content of the files. Thanks! |
|
@bryanwweber so you think just having all the YAML files in a top-level directory is best? I am fine with that too. |
|
@kyleniemeyer Yeah, I think just having a flat structure below the top level directories for fuels is probably the easiest. We really really need to resolve #9 if people are going to actually start using this database. |
|
@bryanwweber got it. @MariaPoliti in addition to the other edits, can you remove the sub-folders and just have all of the files in the |
|
I will make these changes and upload a new version of the 'hydrogen' folder in the next few day |
|
Hi @MariaPoliti, it looks like you deleted the old files (in all the folders), but did not add them in their new location via ( (Also, for future reference you can just use |
|
@kyleniemeyer thank you for letting me know. I will try to add the files again in the new folder. Sorry for the inconvenience! |
The file name is usually based on:
~ Authors' name
~ Year of publication
~ Type of apparatus: ST or RCM
~ Mixture number (based on the one listed in the journal article)
~ Equivalence ratio
The files contain uncertainties for composition or data and pressure rises [ if mentioned in the journal article].
If the composition data did not add up to exactly 1.00, the inert fraction was varied for validation purposes [Usual variation did not exceed +/- 0.01].
Files converted from ReSpecTh files database present the reference to the original .xml file in the detail field.
Hydrogen References.xlsx