Skip to content

Run getGlobalVisibleRect on the main thread instead of a background thread #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsligh merged 4 commits into from
Jan 19, 2024
Merged

Run getGlobalVisibleRect on the main thread instead of a background thread #736

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c739139
Run getGlobalVisibleRect on the main thread instead of a background t…
jsligh Jan 17, 2024
ea55c56
Crash that does keep occurring in my testing.
jsligh Jan 18, 2024
50d4c66
Fixed to run synchronously.
jsligh Jan 18, 2024
cb27587
Forgot important step.
jsligh Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions ...e-core/src/main/java/org/prebid/mobile/rendering/views/webview/mraid/BaseJSInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@
import org.prebid.mobile.rendering.views.webview.WebViewBase;

import java.lang.ref.WeakReference;
import java.util.concurrent.FutureTask;
import java.util.concurrent.RunnableFuture;

@SuppressLint("NewApi")
public class BaseJSInterface implements JSInterface {
Expand Down Expand Up @@ -119,9 +121,11 @@ public String getMaxSize() {
JSONObject maxSize = new JSONObject();
try {
final Rect currentMaxSizeRect = screenMetrics.getCurrentMaxSizeRect();
maxSize.put(JSON_WIDTH, currentMaxSizeRect.width());
maxSize.put(JSON_HEIGHT, currentMaxSizeRect.height());
return maxSize.toString();
if (currentMaxSizeRect != null) {
maxSize.put(JSON_WIDTH, currentMaxSizeRect.width());
maxSize.put(JSON_HEIGHT, currentMaxSizeRect.height());
return maxSize.toString();
}
}
catch (Exception e) {
LogUtil.error(TAG, "Failed getMaxSize() for MRAID: " + Log.getStackTraceString(e));
Expand Down Expand Up @@ -171,10 +175,12 @@ public String getDefaultPosition() {
public String getCurrentPosition() {
JSONObject position = new JSONObject();
Rect rect = new Rect();

adBaseView.getGlobalVisibleRect(rect);

Handler mainHandler = new Handler(Looper.getMainLooper());
Runnable mainThreadRunnable = () -> adBaseView.getGlobalVisibleRect(rect);
RunnableFuture<Void> task = new FutureTask<>(mainThreadRunnable, null);
try {
mainHandler.post(task);
task.get();
position.put(JSON_X, (int) (rect.left / Utils.DENSITY));
position.put(JSON_Y, (int) (rect.top / Utils.DENSITY));
position.put(JSON_WIDTH, (int) (rect.right / Utils.DENSITY - rect.left / Utils.DENSITY));
Expand Down
⚡