Skip to content

Update#5

Merged
vweevers merged 4 commits intomasterfrom
update-for-prebuildify-4
Apr 28, 2019
Merged

Update#5
vweevers merged 4 commits intomasterfrom
update-for-prebuildify-4

Conversation

@vweevers
Copy link
Copy Markdown
Member

@vweevers vweevers commented Apr 27, 2019 •
edited
Loading

Closes #4.

I smoke-tested android-arm64 locally with Level/leveldown#625:

$ file prebuilds/android-arm64/node.napi.armv8.node
prebuilds/android-arm64/node.napi.armv8.node: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, stripped, with debug_info

@vweevers vweevers requested a review from ralphtheninja April 27, 2019 09:29
This was referenced Apr 27, 2019
Merged
Closed
@vweevers
Copy link
Copy Markdown
Member Author

vweevers commented Apr 27, 2019

Also closes #6 (tested locally with --tag-libc).

@vweevers
Copy link
Copy Markdown
Member Author

vweevers commented Apr 28, 2019

I'm gonna try to setup autobuilds, in the interest of learning something new :)

With a machine user (prebuild-ci per prebuild/prebuild-install#62), I'm thinking

@vweevers
Copy link
Copy Markdown
Member Author

vweevers commented Apr 28, 2019

image

:)

@vweevers vweevers changed the title Add new environment variables for prebuildify@3 Update Apr 28, 2019
@vweevers vweevers merged commit c91560b into master Apr 28, 2019
@vweevers vweevers deleted the update-for-prebuildify-4 branch April 28, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update for prebuildify@3

2 participants

@vweevers @ralphtheninja
⚡