prebuild-install doesn't find binaries

[matteodisabatino]

I recently have released an npm module, that is a C++ addon, using prebuild to compile binaries. Here my CI (I use github actions):

name: CI

on:
  push:
    branches: [master]

jobs:
  release:
    runs-on: ubuntu-latest

    env:
      GITHUB_TOKEN: ${{ secrets.AT }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git config user.email "matteo.di.sabatino.1989@gmail.com"
          git config user.name "Matteo Di Sabatino"
          npm i
          npm test
          npm run release

  build-linux:
    needs: release

    runs-on: ubuntu-latest

    env:
      GITHUB_TOKEN: ${{ secrets.AT }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git pull
          npm i
          npm run prebuild -- -u $GITHUB_TOKEN

  build-macos:
    needs: release

    runs-on: macos-latest

    env:
      GITHUB_TOKEN: ${{ secrets.AT }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git pull
          npm i
          npm run prebuild -- -u $GITHUB_TOKEN

  build-windows:
    needs: release

    runs-on: windows-latest

    env:
      GITHUB_TOKEN: ${{ secrets.AT }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git pull
          npm i
          npm run prebuild -- -u %GITHUB_TOKEN%

  publish:
    needs: [build-linux, build-macos, build-windows]

    runs-on: ubuntu-latest

    env:
      NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v1
        with:
          node-version: "14"
      - run: |
          git pull
          echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > .npmrc
          npm publish --access=public

As you can read, first I use the module release-it in order to update the changelog, create the tag and the release, but not publish to npm. Then I build the source for Linux, macOS and Windows and, finally, I publish the module to npm.

I supposed all worked fine since the binaries have been attached to the release (see here) but I was wrong in fact, if I try to install my module via npm i @matteodisabatino/gc_info, I receive this warning prebuild-install WARN install No prebuilt binaries found (target=14.15.5 runtime=node arch=x64 libc=musl platform=linux).

I suppose this mean that the binaries are attached to the release but npm was not able to find them. What am I wronging?

P.S.: the command npm run prebuild runs prebuild --target 64 --target 72 --target 83 --target 88 --force --strip --tag-prefix \"\" since I decided to compile for Node.js 10, 12, 14 and 15 only.

[mathiask88]

prebuild-install WARN install No prebuilt binaries found (target=14.15.5 runtime=node arch=x64 libc=musl platform=linux)

Your prebuilds are linked against glibc and you are running a musl based distro. I don't see musl prebuilds in your release assets so prebuild-install is correct with the warning.

[matteodisabatino]

You gotta reason: I didn't know that alpine switched to musl. Sorry.

But using node:14-buster I also receive an error: prebuild-install WARN install No prebuilt binaries found (target=14.15.5 runtime=node arch=x64 libc= platform=linux). It seems prebuild-install was unable to find the libc version. Should I install some Debian package?

Moreover, is there a way to compile either against gblic and musl in order to use binaries with alpine too?

[mathiask88]

Ah, I see.. your tag format is not the default. Either rename your tags with a prefixed v like v0.0.2 or change your install script to overwrite the default prefix with --tag-prefix <prefix> (github tag prefix, default is "v") to match your choice.

I don't have any experience with building against musl via CI but I think Github workflows can do something like

  alpine-linux:
    name: alpine 3.11.6 (musl)
    runs-on: ubuntu-18.04
    container: alpine:3.11.6

[matteodisabatino]

Thank you very much for your support 😀

[matteodisabatino]

Hi @mathiask88, sorry to bother again but I still have got problems: I created a new release in which I added tag prefix also for install (commit) but, despite this I'm still unable to download the binary.

I repeated the test of yesterday: I created a node container using image node:14-buster and then I installed my module but still I receive this error:

prebuild-install WARN install No prebuilt binaries found (target=14.15.5 runtime=node arch=x64 libc= platform=linux)

Very strange... seems like libc version is undefined.

[mathiask88]

Okay, so now we are talking about an issue :) Problem is this check in https://github.com/prebuild/prebuild-install/blob/master/util.js#L26 We currently ignore/overwrite empty tag prefixes. IMHO this should not be the intended behaviour. What do you think @vweevers ? @ralphtheninja as well, you had the wish for that check in #90 (comment) :)

[matteodisabatino]

Ok, I'll what for this clarification. If the exposed one is the correct behaviour, the only thing I can do is modify release-it options in order to prepend the "v" to the releases and the delete the option the option --tag-prefix "" to prebuild and prebuild-install. But I don't know if it's possibile. We will see 😄

[ralphtheninja]

Okay, so now we are talking about an issue :) Problem is this check in https://github.com/prebuild/prebuild-install/blob/master/util.js#L26 We currently ignore/overwrite empty tag prefixes. IMHO this should not be the intended behaviour. What do you think @vweevers ? @ralphtheninja as well, you had the wish for that check in #90 (comment) :)

So the provided tag prefix is an empty string, which is falsey and then it falls back to 'v' anyway?

[mathiask88]

Okay, so now we are talking about an issue :) Problem is this check in https://github.com/prebuild/prebuild-install/blob/master/util.js#L26 We currently ignore/overwrite empty tag prefixes. IMHO this should not be the intended behaviour. What do you think @vweevers ? @ralphtheninja as well, you had the wish for that check in #90 (comment) :)

So the provided tag prefix is an empty string, which is falsey and then it falls back to 'v' anyway?

Correct and we set the default in rc.js anyway.

[ralphtheninja]

@matteodisabatino So if I understand correctly, your release use case looks something like:

1. you tag gc_info, like git tag 0.0.6 && git push --tags
2. github actions
3. npm run release
4. release-it --ci

Is this correct?

[matteodisabatino]

Hi @ralphtheninja,
No, the workflow is:

• git push
• github actions (=CI)
  • npm run release (=release-it --ci) --> this creates the release and the tag and updates the changelog
  • npm run prebuild (attach the binaries to the previously created release)
  • npm publish

[ralphtheninja]

@matteodisabatino Ah ok. And how does release-it determine which tag to set? Is that the https://github.com/release-it/conventional-changelog defined in your .release-it.json config?