Skip to content
This repository was archived by the owner on Feb 19, 2026. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions asset.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
var get = require('simple-get')
var util = require('./util')
var proxy = require('./proxy')
var noop = Object.assign({
http: function () {},
silly: function () {}
}, require('noop-logger'))

function findAssetId (opts, cb) {
var downloadUrl = util.getDownloadUrl(opts)
var apiUrl = util.getApiUrl(opts)
var log = opts.log || noop
var log = opts.log || util.noopLogger

log.http('request', 'GET ' + apiUrl)
var reqOpts = proxy({
Expand Down
6 changes: 1 addition & 5 deletions download.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ var fs = require('fs')
var get = require('simple-get')
var pump = require('pump')
var tfs = require('tar-fs')
var noop = Object.assign({
http: function () {},
silly: function () {}
}, require('noop-logger'))
var zlib = require('zlib')
var util = require('./util')
var error = require('./error')
Expand All @@ -17,7 +13,7 @@ function downloadPrebuild (downloadUrl, opts, cb) {
var cachedPrebuild = util.cachedPrebuild(downloadUrl)
var localPrebuild = util.localPrebuild(downloadUrl, opts)
var tempFile = util.tempFile(cachedPrebuild)
var log = opts.log || noop
var log = opts.log || util.noopLogger

if (opts.nolocal) return download()

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"mkdirp-classic": "^0.5.3",
"napi-build-utils": "^1.0.1",
"node-abi": "^2.21.0",
"noop-logger": "^0.1.1",
"npmlog": "^4.0.1",
"pump": "^3.0.0",
"rc": "^1.2.7",
Expand Down
7 changes: 2 additions & 5 deletions proxy.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
var url = require('url')
var tunnel = require('tunnel-agent')
var noop = Object.assign({
http: function () {},
silly: function () {}
}, require('noop-logger'))
var util = require('./util')

function applyProxy (reqOpts, opts) {
var log = opts.log || noop
var log = opts.log || util.noopLogger

var proxy = opts['https-proxy'] || opts.proxy

Expand Down
16 changes: 16 additions & 0 deletions util.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,21 @@ function localPrebuild (url, opts) {
return path.join(prefix, path.basename(url))
}

var noopLogger = {
http: function () {},
silly: function () {},
debug: function () {},
info: function () {},
warn: function () {},
error: function () {},
critical: function () {},
alert: function () {},
emergency: function () {},
notice: function () {},
verbose: function () {},
fatal: function () {}
}

exports.getDownloadUrl = getDownloadUrl
exports.getApiUrl = getApiUrl
exports.getAssetUrl = getAssetUrl
Expand All @@ -125,3 +140,4 @@ exports.prebuildCache = prebuildCache
exports.npmCache = npmCache
exports.tempFile = tempFile
exports.packageOrigin = packageOrigin
exports.noopLogger = noopLogger