This repository was archived by the owner on Feb 19, 2026. It is now read-only.
deps: update node-abi so that electron 14+ get correct node-abi#161
Merged
vweevers merged 2 commits intoprebuild:masterfrom Nov 12, 2021
csett86:update-node-abi
Merged
deps: update node-abi so that electron 14+ get correct node-abi#161vweevers merged 2 commits intoprebuild:masterfrom csett86:update-node-abi
vweevers merged 2 commits intoprebuild:masterfrom
csett86:update-node-abi
Conversation
electron/node-abi#113 was fixed in 3.3.0 and is affecting electron 14+ With the current node-abi prebuild-install will download ABI 89 for electron 14 and 15 and then modules will fail to load as electron 14 has ABI 97 and electon 15 has ABI 98 in reality.
Member
|
We'll need to drop support of Node < 10 because @prebuild/builders Thumbs up or down for dropping Node < 10? |
Member
I would take the opportunity to also drop Node < 12, since it's not a maintained version anymore. If not, we'll need to update major version again in the future. |
Member
That will happen in any case. If not for 12 then for 14 or 16. If there's no effort in supporting a version, as is the case with Node.js 12 atm, we can keep it. Doing it now doesn't save time and hurts folks that are behind the Node.js LTS schedule. |
node-abi 3.0.0 did so too
vweevers
approved these changes
Nov 7, 2021
This was referenced Nov 9, 2021
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
electron/node-abi#113 was fixed in 3.3.0
and is affecting electron 14+
With the current node-abi prebuild-install will download ABI 89 for
electron 14 and 15 and then modules will fail to load as electron 14
has ABI 97 and electon 15 has ABI 98 in reality.