feat: ✨ Add TypeScript definitions#739
Conversation
kylemh
left a comment
There was a problem hiding this comment.
🔥 This is a good intermediary, but - in the future - it'd be better (IMO) to change the source code to TS, run the tsc, and ship the compiled bundle + types.
|
Shall we? I'm hella down for that but it's gonna take time |
|
That's what I was trying to get across in DefinitelyTyped/DefinitelyTyped#54526 No need to do type declarations if we just go to TypeScript. As an aside, it appears as though this has caused CI to fail 👀 |
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 99.65% 99.66% +0.01%
==========================================
Files 2 2
Lines 287 298 +11
Branches 78 88 +10
==========================================
+ Hits 286 297 +11
Misses 1 1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Moved here from DefinitelyTyped/DefinitelyTyped#54526 - see context in #575.
@kylemh