Skip to content

feat: ✨ Add TypeScript definitions#739

Merged
kylemh merged 2 commits intomasterfrom
unknown repository
May 14, 2022
Merged

feat: ✨ Add TypeScript definitions#739
kylemh merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 7, 2022

Moved here from DefinitelyTyped/DefinitelyTyped#54526 - see context in #575.

@kylemh

Copy link
Copy Markdown
Collaborator

@kylemh kylemh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 This is a good intermediary, but - in the future - it'd be better (IMO) to change the source code to TS, run the tsc, and ship the compiled bundle + types.

@ghost
Copy link
Copy Markdown
Author

ghost commented May 7, 2022

Shall we? I'm hella down for that but it's gonna take time

@kylemh
Copy link
Copy Markdown
Collaborator

kylemh commented May 7, 2022

That's what I was trying to get across in DefinitelyTyped/DefinitelyTyped#54526

No need to do type declarations if we just go to TypeScript.

As an aside, it appears as though this has caused CI to fail 👀

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2022

Codecov Report

Merging #739 (4a08a4e) into master (c425280) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   99.65%   99.66%   +0.01%     
==========================================
  Files           2        2              
  Lines         287      298      +11     
  Branches       78       88      +10     
==========================================
+ Hits          286      297      +11     
  Misses          1        1              
Impacted Files Coverage Δ
src/utils.js 100.00% <0.00%> (ø)
src/index.js 99.20% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c425280...4a08a4e. Read the comment docs.

@kylemh kylemh merged commit b271486 into prettier:master May 14, 2022
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 14.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants