You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR doesn't seem to contain any updated Unit Test for Kotlin 🤔. Please consider double checking it 🙏
⚠️
/home/runner/work/primer-sdk-react-native/primer-sdk-react-native/android/src/main/java/com/primerioreactnative/DefaultNativePrimerModule.kt#L3 - Detekt: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end Rule: detekt.ImportOrdering
⚠️
/home/runner/work/primer-sdk-react-native/primer-sdk-react-native/android/src/main/java/com/primerioreactnative/DefaultNativePrimerModule.kt#L274 - Detekt: Function parameter clientToken is unused. Rule: detekt.UnusedParameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setupAnalyticsLoggingBridge,trackAnalyticsEvent, andsendLogTurboModule bridge methods across iOS and Android (old/new arch)PrimerAnalyticspublic API withsetup,trackEvent, andsendLogmethodsComponentsAnalyticsLoggingBridgeintegration on iOS (self-contained) and Android (DI-based via headless flow)Jira
ACC-6493
Test plan
npx tsc --noEmitpassesnpm test— 21/21 tests pass