Skip to content

feat: add PrimerPaymentMethodList and checkout flow (ACC-6492)#343

Open
OnurVar wants to merge 1 commit intoov/feat/componentsfrom
ov/feat/ACC-6492
Open

feat: add PrimerPaymentMethodList and checkout flow (ACC-6492)#343
OnurVar wants to merge 1 commit intoov/feat/componentsfrom
ov/feat/ACC-6492

Conversation

@OnurVar
Copy link
Copy Markdown
Contributor

@OnurVar OnurVar commented Apr 14, 2026

Summary

Drop-in UI for the new Checkout Components SDK.

  • PrimerPaymentMethodList — renders payment method buttons from usePaymentMethods(). Card renders outlined with "Pay with card"; other methods render as filled logo buttons, with per-method surcharge and include/exclude filtering. Pass data to bypass the hook when methods are already fetched.
  • PrimerCheckoutSheet — opinionated wrapper that composes CheckoutSheet with CheckoutFlow so merchants get the whole thing in one component.
  • CheckoutFlow — shows LoadingScreen until the SDK is ready, then transitions to MethodSelectionScreen.
  • MethodSelectionScreen — localized "Choose payment method" header, auto-sizing sheet height, bottom-inset and drag-handle spacing reserved.
  • CheckoutSheet — fixes the open animation being skipped when the component mounts with visible=true (prevVisibleRef was seeded from the current value).
  • Example app: new "Checkout Components" screen creates a session and opens the sheet.

Jira

ACC-6492

Test plan

  • yarn lint
  • yarn typecheck
  • yarn test — 85/85
  • Tap "Checkout Components" → "Default" → sheet opens with loading, then shows method list
  • Cancel button dismisses the sheet
  • Backdrop tap dismisses the sheet
  • Sheet height scales to the number of methods

@OnurVar OnurVar requested a review from a team as a code owner April 14, 2026 16:33
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test for Swift 🤔. Please consider double checking it 🙏
Messages
📖 ✅ No SwiftLint violations found.

Generated by 🚫 Danger Swift against c42b7c5

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test for Kotlin 🤔. Please consider double checking it 🙏
Messages
📖 ✅ No detekt violations found.

Generated by 🚫 Danger Kotlin against c42b7c5

Copy link
Copy Markdown

@unblocked unblocked Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found.

About Unblocked

Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.

📖 Documentation — Learn more in our docs.

💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions about your code.

👍 Give feedback — React to comments with 👍 or 👎 to help us improve.

⚙️ Customize — Adjust settings in your preferences.

Comment thread src/Components/internal/screens/MethodSelectionScreen.tsx Outdated
Comment thread src/Components/PrimerPaymentMethodList.tsx Outdated
@github-actions
Copy link
Copy Markdown

Appetize Android link: https://appetize.io/app/kccft6zs2fyl54gpqoxdmln26m

@OnurVar OnurVar self-assigned this Apr 14, 2026
@OnurVar OnurVar marked this pull request as draft April 14, 2026 16:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026

Appetize iOS link: https://appetize.io/app/ew36kl664xmwx7isnlgm7ot4sm

@OnurVar OnurVar changed the title feat: add PrimerPaymentMethodList and checkout flow feat: add PrimerPaymentMethodList and checkout flow (ACC-6492) Apr 14, 2026
@OnurVar OnurVar force-pushed the ov/feat/ACC-6917 branch 2 times, most recently from ba9d1c7 to 0b7eb49 Compare April 15, 2026 22:05
@OnurVar OnurVar force-pushed the ov/feat/ACC-6917 branch 2 times, most recently from e413805 to 9fae729 Compare April 15, 2026 23:16
@OnurVar OnurVar force-pushed the ov/feat/ACC-6492 branch 2 times, most recently from 70bbf52 to bb0959a Compare April 19, 2026 15:39
@OnurVar OnurVar force-pushed the ov/feat/ACC-6917 branch 2 times, most recently from e357314 to bf8cbef Compare April 20, 2026 14:29
@OnurVar OnurVar force-pushed the ov/feat/ACC-6492 branch 4 times, most recently from 71d1bf2 to 13f4905 Compare April 21, 2026 17:16
Base automatically changed from ov/feat/ACC-6917 to ov/feat/components April 23, 2026 14:37
@OnurVar OnurVar marked this pull request as ready for review April 23, 2026 15:54
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@OnurVar OnurVar force-pushed the ov/feat/components branch from f69fdb6 to 09ef1a0 Compare April 23, 2026 23:28
@github-actions
Copy link
Copy Markdown

Warnings
⚠️ Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PRs for a faster, easier review.
Messages
📖 ✅ No ESLint violations found.

Generated by 🚫 dangerJS against c42b7c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants