feat: add useCardForm() hook with tokenization and 3DS (ACC-6925)#346
Draft
OnurVar wants to merge 1 commit intoov/feat/ACC-6492from
Draft
feat: add useCardForm() hook with tokenization and 3DS (ACC-6925)#346OnurVar wants to merge 1 commit intoov/feat/ACC-6492from
OnurVar wants to merge 1 commit intoov/feat/ACC-6492from
Conversation
Generated by 🚫 Danger Swift against d6c9c11 |
Generated by 🚫 Danger Kotlin against d6c9c11 |
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 issues found.
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions about your code.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
|
Appetize Android link: https://appetize.io/app/iuefsgpuqgjtcbcbyy6tqrvybi |
|
Appetize iOS link: https://appetize.io/app/ky32djjab7giv4h7llx3bnjiwi |
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
from
69e4942 to
5b1aa88
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
from
9b3f3e8 to
95f2be8
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
from
5b1aa88 to
6e6e96f
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
2 times, most recently
from
2ad0a1c to
70bbf52
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
from
6e6e96f to
534cef6
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
from
70bbf52 to
bb0959a
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
from
534cef6 to
15c3bb8
Compare
| setIsInitialized(true); | ||
| } catch (err) { | ||
| if (!cancelled) { | ||
| console.error('[useRawDataManagerBridge] init failed:', err); |
There was a problem hiding this comment.
How confident are we that the sensitive card info cant be emitted here? Passing the whole error gives me pause, in case the err might contain the raw input there could be potential to leak the PAN/CVV?
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
2 times, most recently
from
234f02d to
d6c9c11
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
from
bb0959a to
a725da4
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
from
a725da4 to
0d27802
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
from
d6c9c11 to
b7b5a75
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
from
0d27802 to
2f412f5
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
2 times, most recently
from
83e7493 to
6cb3a53
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
from
3fb9961 to
71d1bf2
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
from
6cb3a53 to
b11b6e4
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
from
71d1bf2 to
13f4905
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
from
b11b6e4 to
2549108
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
from
2549108 to
3b5bc82
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
3 times, most recently
from
05e7ea6 to
3d72c17
Compare
…925) Backs the card form with a provider-managed raw-data lifecycle on PrimerCheckoutProvider (activeMethod, cardFormState, setRawData, submit, retry, clearPaymentOutcome, paymentOutcome, settings). The hook forwards field updates to the provider and surfaces validation state without owning the native manager, so the manager survives nav transitions.
OnurVar
force-pushed
the
ov/feat/ACC-6925
branch
from
3b5bc82 to
334668f
Compare
OnurVar
force-pushed
the
ov/feat/ACC-6492
branch
from
3d72c17 to
c42b7c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useCardForm()hook that wraps RawDataManager to provide managed card form state, auto-formatting, touch-based validation, debounced native sync, BIN detection, and guarded submit for tokenization/3DSuseRawDataManagerBridgeinternal hook managing RawDataManager lifecycle, event subscription, and cleanupCardFormTypeswithUseCardFormOptions,UseCardFormReturn,CardFormErrors,CardFormFielddebounceutility insrc/utils/debounce.tsuseCardFormand types from package rootJira
ACC-6925
Test plan
npm run lint— cleannpm test— 32/32 tests passnpx tsc --noEmit— no TypeScript errors