feat: Card network detection with icons and native-sourced traits (ACC-6915)#352
Draft
OnurVar wants to merge 1 commit intoov/feat/ACC-6495from
Draft
feat: Card network detection with icons and native-sourced traits (ACC-6915)#352OnurVar wants to merge 1 commit intoov/feat/ACC-6495from
OnurVar wants to merge 1 commit intoov/feat/ACC-6495from
Conversation
a642c03 to
eb0c92c
Compare
ab90f37 to
62691a0
Compare
eb0c92c to
2b52fa1
Compare
62691a0 to
526ecf5
Compare
2b52fa1 to
41baa66
Compare
41baa66 to
a297f67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetsManager.getCardNetworkTraitsTS method + iOS / Android bridgesuseCardNetwork()exposes{ network, descriptor, iconSource }useCardForm()consumes traits throughuseCardNetworkDepends on
ov/feat/ACC-7167(exposesPrimerCardNetworkTraits)ov/feat/ACC-7168(addscvvLabeltoDescriptor)Test plan
yarn jest— 126/126yarn typecheck— no new errors