Port custom icons from feedback modals#1133
Merged
Conversation
🦋 Changeset detectedLatest commit: e3e4ead The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
approved these changes
Nov 10, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ports custom smiley icons from feedback modals by adding four new emoji icon variants to support different sentiment levels in feedback interfaces.
- Adds four new smiley icon variants (frown, frustrated, grin, neutral) in both 16px and 24px sizes
- Updates keywords.json to include search terms for all smiley icons, with feedback sentiment ratings (1-5)
Reviewed Changes
Copilot reviewed 1 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| keywords.json | Adds keywords for new smiley icons with feedback ratings and emotion descriptors |
| icons/smiley-neutral-16.svg | Adds 16px neutral smiley icon for feedback rating 3 |
| icons/smiley-neutral-24.svg | Adds 24px neutral smiley icon for feedback rating 3 |
| icons/smiley-grin-16.svg | Adds 16px grin smiley icon for feedback rating 5 |
| icons/smiley-grin-24.svg | Adds 24px grin smiley icon for feedback rating 5 |
| icons/smiley-frustrated-16.svg | Adds 16px frustrated smiley icon for feedback rating 1 |
| icons/smiley-frustrated-24.svg | Adds 24px frustrated smiley icon for feedback rating 1 |
| icons/smiley-frown-16.svg | Adds 16px frown smiley icon for feedback rating 2 |
| icons/smiley-frown-24.svg | Adds 24px frown smiley icon for feedback rating 2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nto mp/feedback-icons-port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figma file where these were worked on.
These have already been added to Octicons v2 - Source file