Chore: make data-component attribute overridable#1190
Merged
francinelucca merged 4 commits intomainfrom Apr 15, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: aa9c187 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables consumers of the @primer/octicons React icon components to override the data-component attribute on the rendered <svg>, and adds tests verifying both the default and overridden behavior.
Changes:
- Move the default
data-component="Octicon"attribute so consumer-provided props can override it. - Add/extend unit tests in both
octicons_reactandocticons_styledto cover the override behavior. - Add a changeset entry documenting the patch.
Show a summary per file
| File | Description |
|---|---|
| lib/octicons_react/src/createIconComponent.js | Reorders props on <svg> so data-component can be overridden via ...rest. |
| lib/octicons_react/src/tests/octicon.js | Adds a test ensuring data-component override works for React icons. |
| lib/octicons_styled/src/tests/octicon.js | Adds tests for default and overridden data-component in styled icons. |
| .changeset/data-component-override.md | Records the change as a patch release note. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 1
liuliu-dev
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows consumers of the
@primer/octiconsReact components to override thedata-componentattribute on the rendered SVG elements. It also adds tests to ensure the default and overridden behaviors work as expected.