Test for duplicate icon names and fail when two icons have the same name#322
Merged
jonrohan merged 9 commits intorelease-9.1.1from Jun 21, 2019
Merged
Test for duplicate icon names and fail when two icons have the same name#322jonrohan merged 9 commits intorelease-9.1.1from
jonrohan merged 9 commits intorelease-9.1.1from
Conversation
jonrohan
changed the title
shawnbot
reviewed
Jun 20, 2019
shawnbot
reviewed
Jun 20, 2019
shawnbot
approved these changes
Jun 20, 2019
Contributor
shawnbot
left a comment
shawnbot
left a comment
There was a problem hiding this comment.
I just had a couple of very minor suggestions; otherwise this looks good. Thanks for adding this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caveat: This isn't currently failing because the data being output needs massaging. We're currently using a sha'd version of the exporter because I haven't had time to adjust the build processes for data structure changes.
When this does work it will go through each icon and test if there's another icon with the same name but different figma id. When that happens it will fail.