Skip to content

Renames trashcan-16 icon to trash-16#538

Merged
edokoa merged 2 commits intoprimer:release-12.0.0from
fermion:fix-trash-16-icon-name
Feb 4, 2021
Merged

Renames trashcan-16 icon to trash-16#538
edokoa merged 2 commits intoprimer:release-12.0.0from
fermion:fix-trash-16-icon-name

Conversation

@fermion
Copy link
Copy Markdown

@fermion fermion commented Jan 20, 2021

Fixes #537

I've been using primer for a personal project of mine and noticed last night that one of the trash and trashcan icons was incorrectly named.

🙇🏻

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/c70ubavl3
✅ Preview: https://octicons-git-fork-fermion-fix-trash-16-icon-name.primer.vercel.app

@vercel vercel Bot temporarily deployed to Preview January 20, 2021 21:09 Inactive
@colebemis
Copy link
Copy Markdown
Contributor

Thanks for the PR, @fermion! ❤️

This is technically a breaking change so I'll handle releasing a new major version.

@vercel vercel Bot temporarily deployed to Preview February 4, 2021 17:10 Inactive
@edokoa edokoa changed the base branch from master to release-12.0.0 February 4, 2021 17:54
@edokoa edokoa merged commit e0e204f into primer:release-12.0.0 Feb 4, 2021
@edokoa edokoa mentioned this pull request Feb 4, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naming discrepancy of trash and trashcan icons?

3 participants