[Bug] up/down chevron alignment#894
Merged
langermank merged 29 commits intomainfrom Jan 20, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: fadb376 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
|
Going to add this to the Octicons agenda for next Wednesday. |
tallys
approved these changes
Jan 18, 2023
Contributor
tallys
left a comment
tallys
left a comment
There was a problem hiding this comment.
Haven't heard any concerns about aligning the icon. If we can bundle this with addressing any visual regressions in buttons (if that was the original reason for the misalignment) let's do it.
langermank
had a problem deploying
to
github-pages
GitHub Actions
Failure
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
force-pushed
the
chevron-vertical-alignment-bug
branch
from
80eac50 to
9fee24d
Compare
langermank
force-pushed
the
chevron-vertical-alignment-bug
branch
from
9fee24d to
8aee6b6
Compare
github-actions
Bot
force-pushed
the
chevron-vertical-alignment-bug
branch
from
b4bc3f4 to
c890516
Compare
github-actions
Bot
force-pushed
the
chevron-vertical-alignment-bug
branch
3 times, most recently
from
84452a3 to
984e506
Compare
…rimer/octicons into chevron-vertical-alignment-bug
…rimer/octicons into chevron-vertical-alignment-bug
…rimer/octicons into chevron-vertical-alignment-bug
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
Author
|
Here's a preview of how these changes will impact Primer React https://primer-3ab97043a8-13348165.drafts.github.io/storybook/?path=/story/components-iconbutton-features--chevron-test |
gavinmn
approved these changes
Jan 20, 2023
Merged
This was referenced Sep 9, 2024
This was referenced Sep 10, 2024
This was referenced Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/1673
This PR adjusts where the SVG sits within the frame to improve horizontal alignment between these related icons.
Before
After
Concerns