refactor: simplify registration of style definitions#3334
Merged
Conversation
Use functions instead of classes. bpmn-visualization doesn't provide extension points for the registration, so using internal functions is simpler than having classes with a single method.
|
♻️ PR Preview 5c50faa has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 5c50faa has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use functions instead of classes.
bpmn-visualizationdoesn't provide extension points for the registration, so using internal functions is simpler than having classes with a single method.EXTRA: in the CI workflow running the e2e tests, temporarily exclude running tests with Chrome on ubuntu as they fail.
This will be fixed later by adujsting the failure thresholds and/or bumping playwright.
Notes
This is based on improvements detected during the maxGraph migration evaluation. See #3238