Skip to content

fix!: ShapeUtil does not include BPMN artifacts in flow node kinds #3398

Merged
tbouffard merged 2 commits intomasterfrom
fix/shapeutil_no_artifact_in_flownode
Oct 9, 2025
Merged

fix!: ShapeUtil does not include BPMN artifacts in flow node kinds #3398
tbouffard merged 2 commits intomasterfrom
fix/shapeutil_no_artifact_in_flownode

Conversation

@tbouffard
Copy link
Copy Markdown
Member

@tbouffard tbouffard commented Oct 8, 2025

Regarding the BPMN semantic, artifacts are not executable flow nodes so they are no longer returned in the result of the
ShapeUtil.flowNodeKinds method.

BREAKING CHANGES: artifacts are no longer considered as flow nodes.
Code using the ShapeUtil.flowNodeKinds method may need to be updated to concatenate the array returned by the ShapeUtil.artifactKinds method and restore the previous behavior.

@tbouffard tbouffard added bug Something isn't working BPMN diagram usability Something about the way we can interact with BPMN diagrams labels Oct 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2025

🎊 PR Preview d7f2b76 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3398.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2025

🎊 PR Preview d7f2b76 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3398.surge.sh

🕐 Build time: 0.012s

🤖 By surge-preview

@tbouffard tbouffard removed the BPMN diagram usability Something about the way we can interact with BPMN diagrams label Oct 8, 2025
Regarding the BPMN semantic, artifacts are not executable flow nodes so they are no longer returned in the result of the
`ShapeUtil.flowNodeKinds` method.

BREAKING CHANGES: artifacts are no longer considered as flow nodes. Code using the `ShapeUtil.flowNodeKinds` method may
need to be updated to concat the array returned by the `ShapeUtil.artifactKinds` method to restore the previous content.
@tbouffard tbouffard force-pushed the fix/shapeutil_no_artifact_in_flownode branch from 7bffbb3 to d7f2b76 Compare October 9, 2025 10:39
@tbouffard tbouffard marked this pull request as ready for review October 9, 2025 10:43
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 9, 2025

Comment thread src/component/parser/json/converter/ProcessConverter.ts
@tbouffard tbouffard marked this pull request as draft October 9, 2025 12:18
@tbouffard tbouffard marked this pull request as ready for review October 9, 2025 12:35
@tbouffard tbouffard merged commit 4d106c1 into master Oct 9, 2025
1 check passed
@tbouffard tbouffard deleted the fix/shapeutil_no_artifact_in_flownode branch October 9, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant