Enhance checks for OpenSSL#40582
Merged
andy31415 merged 1 commit intoproject-chip:v1.1-branchfrom Aug 14, 2025
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a change that fixes a potential null pointer dereference in VerifyAttestationCertificateFormat when handling X.509 certificates. The functions X509_get0_subject_key_id and X509_get0_authority_key_id can return NULL, and the previous code did not handle this case, which could lead to a crash. The change correctly adds nullptr checks before accessing the returned pointers, improving the robustness of the certificate parsing logic. The fix is correct and well-implemented. I have no further comments.
andy31415
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
CI Testing