Disallow icd in branch-v1.3#43298
Merged
andy31415 merged 1 commit intoproject-chip:v1.3-branchfrom Feb 24, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a compile-time check using a preprocessor #error directive to prevent the ICD feature from being enabled on the v1.3 branch. The review includes a suggestion to make the error message more specific to 'LIT ICD' to improve clarity and align with the stated intent in the pull request description.
andy31415
approved these changes
Feb 24, 2026
soares-sergio
changed the title
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 2a1c113. 🟢 All jobs passed!But CI Insights is watching 👀 |
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43291
SDK should not allow incomplete features to be enabled like LIT ICD in v1.3.
We should have a build error in 1.3 branch when LIT ICD feature is enabled because it's not ready.
This may cause issues to clients when interacting with "partial" LIT ICD 1.3
Testing
Verified lit_icd app fails to build