[Realtek] Add boot reason handling in DiagnosticDataProvider#71467
Open
pankore wants to merge 2 commits intoproject-chip:masterfrom
Open
[Realtek] Add boot reason handling in DiagnosticDataProvider#71467pankore wants to merge 2 commits intoproject-chip:masterfrom
pankore wants to merge 2 commits intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Realtek FreeRTOS implementation of GetBootReason to use the platform-specific reset_reason_get() API, mapping the results to standard Matter boot reasons. The review feedback suggests caching the boot reason value to prevent redundant hardware access and potential 'clear-on-read' side effects. Additionally, it is recommended to expand the reset reason mapping to include software and hardware resets if supported by the platform API to improve diagnostic accuracy.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #71467 +/- ##
=======================================
Coverage 54.32% 54.32%
=======================================
Files 1577 1577
Lines 108257 108257
Branches 13401 13401
=======================================
Hits 58806 58806
Misses 49451 49451 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #71467: Size comparison from fdb31db to 33645e4 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #71467: Size comparison from cdb458b to f476d44 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
arkq
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the GetBootReason() function in the DiagnosticDataProvider implementation. It replaces the previous implementation that relied on ConfigurationMgr().GetBootReason() with a direct hardware read using Realtek's reset_reason_get() API from wdt.h.
Related issues
[TC-SU-2.6] NotifyUpdateApplied Command from DUT to OTA-P
TH reads BootReason in General Diagnostics cluster from the DUT. Verify that the returned value of BootReason is
SoftwareUpdateCompleted.
Testing
Tested by building realtek light-switch app and passing TC-SU-2.6.