Add registry option to skip metric sorting#2018
Open
ibobgunardi wants to merge 2 commits into
Open
Conversation
Signed-off-by: Bobby <boby@codelabs.co.id>
ibobgunardi
force-pushed
the
bobi/disable-registry-metric-sorting
branch
from
ad02579 to
6cf8711
Compare
Member
Signed-off-by: Bobby <boby@codelabs.co.id>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #483.
Adds
RegistryOpts.DisableMetricSortingwith option-aware constructors for vanilla and pedantic registries. The existing constructors keep the current sorted output; the new option skips the final MetricFamily/Metric sort for callers that can accept unspecified ordering.Tests:
go test ./prometheus -run TestRegistryDisableMetricSorting -count=1go test ./prometheus -run 'TestRegistry|TestRegisterUnregisterCollector|TestCollectorOnMetricPanic|TestCheckMetricConsistency|TestGatherDoesNotLeakGoroutines' -count=1go test ./prometheus/internal -count=1Note:
go test ./prometheus -count=1fails locally on Go 1.25.1 because the expected Go runtime metric set has 180 entries while this toolchain exposes 177.