Register WP-CLI payment command in cli_init

Extract WP-CLI command registration into a private cli_init() method and hook it to the 'cli_init' action using add_action( 'cli_init', $this->cli_init(... ) ). The 'pay payment status' command behavior is preserved but initialization is deferred to the proper CLI init hook for cleaner startup and better timing.

Author: remcotolsma

src/Payments/PaymentsModule.php

@@ -59,44 +59,50 @@ public function __construct( Plugin $plugin ) {
 		// Payment Status Checker.
 		$this->status_checker = new StatusChecker();
 
-		// CLI.
-		if ( defined( 'WP_CLI' ) && WP_CLI ) {
-			WP_CLI::add_command(
-				'pay payment status',
-				function ( $args ): void {
-					foreach ( $args as $id ) {
-						$payment = get_pronamic_payment( $id );
-
-						if ( null === $payment ) {
-							WP_CLI::error(
-								\sprintf(
-									'Cannot find payment based on ID %s.',
-									$id
-								)
-							);
-						}
-
-						WP_CLI::log(
-							\sprintf(
-								'Check the status (current: %s) of payment with ID %s…',
-								$payment->get_status(),
-								$id
-							)
-						);
-
-						Plugin::update_payment( $payment, false );
+		\add_action( 'cli_init', $this->cli_init( ... ) );
+	}
 
-						WP_CLI::log(
+	/**
+	 * CLI init.
+	 *
+	 * @return void
+	 */
+	private function cli_init() {
+		WP_CLI::add_command(
+			'pay payment status',
+			function ( $args ): void {
+				foreach ( $args as $id ) {
+					$payment = get_pronamic_payment( $id );
+
+					if ( null === $payment ) {
+						WP_CLI::error(
 							\sprintf(
-								'Checked the status (current: %s) of payment with ID %s.',
-								$payment->get_status(),
+								'Cannot find payment based on ID %s.',
 								$id
 							)
 						);
 					}
+
+					WP_CLI::log(
+						\sprintf(
+							'Check the status (current: %s) of payment with ID %s…',
+							$payment->get_status(),
+							$id
+						)
+					);
+
+					Plugin::update_payment( $payment, false );
+
+					WP_CLI::log(
+						\sprintf(
+							'Checked the status (current: %s) of payment with ID %s.',
+							$payment->get_status(),
+							$id
+						)
+					);
 				}
-			);
-		}
+			}
+		);
 	}
 
 	/**