Do something better for calling Proto.from with a proto instead of a JSON. Currently all unset fields get expanded

[robin-anil]

protobuf.js version: 6.5.2

This is causing failures for us on the server side as the has*() semantics are now broken.

[dcodeIO]

Reference: https://github.com/dcodeIO/protobuf.js/blob/master/src/converter.js#L128

[robin-anil]

trying to construct a test case, simple test with a proto with one field passes. So it must be something deeper

[robin-anil]

Gah!!! Found it. Somewhere in our code we are passing protoObj into a MyProto.from(protoObj) instead of JSON. the from happily takes in the proto, expands all the null fields. 🤦‍♂️

Can you help identify such bad call sites and throw a console.warn or fatal error or something. Or maybe do something smarter.

I think V5 handled this correctly in the contructor. Now in V6, I mechanically changed the ctor to from(), didn't realize this folly.

[dcodeIO]

Should now just return the runtime message. That sufficient? 👂

[robin-anil]

haha! yes! that is good. A minor release would be great!

[dcodeIO]

On npm as 6.5.3!