Fixing the packed=true by default problem for proto2 files.

[serkangunes]

Fixing the packed=true by default problem for proto2 files. Packed should be false by default for repeated enums when the syntax is set to proto2.

[coveralls]

Coverage decreased (-0.04%) to 99.957% when pulling dba295a on serkangunes:master into 2ddb76b on dcodeIO:master.

[dcodeIO]

Manually merged your changes and also added some code to Field#resolve removing unnecessary packed options from parsing (again).

[serkangunes]

Ok shall I close this pull request then?

[serkangunes]

I have just had a look at your fix. It does fix my issue however with syntax=proto2 you can still set the repeated fields to be packed. It is just by default unpacked.

var packed = field.getOption('packed');
// There reason packed === undefined check is here because if the user has set the packed option 
// value we should not override it as false.
if (field.repeated && packed === undefined && !isProto3)

[dcodeIO]

field.setOption("packed", false, /* ifNotSet */ true); only sets the value if it is undefined (see).

Is that what you are referring to?

[serkangunes]

Ah good one I didn't notice that parameter. I'll close this.