Skip to content

Fixing the packed=true by default problem for proto2 files. #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serkangunes wants to merge 2 commits into from
Closed

Fixing the packed=true by default problem for proto2 files. #683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75bc576
Update parse.js
serkangunes Feb 20, 2017
dba295a
Update parse.js
serkangunes Feb 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/parse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,8 @@ function parse(source, root, options) {
field.comment = cmnt(trailingLine);
// JSON defaults to packed=true if not set so we have to set packed=false explicity when
// parsing proto2 descriptors without the option, where applicable.
if (field.repeated && types.packed[type] !== undefined && !isProto3)
var packed = field.getOption('packed');
if (field.repeated && packed === undefined && !isProto3)
field.setOption("packed", false, /* ifNotSet */ true);
parent.add(field);
}
Expand Down
⚡