feat: support parsing of complex options

[NikhilVerma]

This allows parsing of complex options and fixes #1743

[NikhilVerma]

@alexander-fenster Will be glad if you could take a look at this

[emarkk]

+1

[NikhilVerma]

In the meanwhile this fix is published as https://www.npmjs.com/package/@cldcvr/protobufjs because I needed it to make https://www.npmjs.com/package/@cldcvr/protobufjs-typescript-gen

[alexander-fenster]

Thank you! This will go into v7.0 that we are going to publish next week.

[alexander-fenster]

@NikhilVerma Would you please fix linting, or grant the contributors write access to your branch? Thank you!

[NikhilVerma]

@alexander-fenster Thank you! I've added you as the collaborator to my repo

[NikhilVerma]

@alexander-fenster I've fixed the lint issues thanks!

[alexander-fenster]

Hi @NikhilVerma,

I switched your PR to be against master so that it goes into 7.0 that we are preparing. Do you mind taking one more look at the diff just to make sure I didn't screw up things? (I needed to resolve a bunch of conflicts)

Also, the CI should be green now so we are good to go after some extra 👀 .

Thank you!

[alexander-fenster]

Actually, the tests now fail with

not ok 848 should take last repeated int in last repeated option

do you have an idea why is that? I can also take a look but it will take me longer to figure out.

[NikhilVerma]

@alexander-fenster While checking I realised I had written some unnecessary code, it already handled arrays just didn't handle them in all conditions. So I've simplified the code and the tests pass now with the simpler code.

[NikhilVerma]

@alexander-fenster Amazing! thanks for the collaboration :) Looking forward to v7

[emarkk]

I'm not sure the issue was fixed though. I have the following Protobuf:

message AwesomeMessage {
  option (option.extension) = {
    scopes: [SCOPE_PRODUCT]
    visibility: VISIBILITY_PUBLIC
  };

  repeated Label labels = 1;

  LabelSource labels_source = 2 [(option.field).visibility=VISIBILITY_INTERNAL];
}

and decoding still fails with error illegal value '[' in line 17 (the line that has scopes: [SCOPE_PRODUCT]).
I thought this PR would fix the issue 😬

[NikhilVerma]

@emarkk Are you using v7.0.0? I just tried this on v7 and it worked fine

syntax = "proto3";

message AwesomeMessage {
  option (option.extension) = {
    scopes: [SCOPE_PRODUCT]
    visibility: VISIBILITY_PUBLIC
  };

  repeated Label labels = 1;

  LabelSource labels_source = 2 [(option.field).visibility=VISIBILITY_INTERNAL];
}

enum LabelSource {
  LABEL_SOURCE_UNKNOWN = 0;
  LABEL_SOURCE_USER = 1;
  LABEL_SOURCE_AUTO = 2;
}

enum Label {
  LABEL_UNKNOWN = 0;
  LABEL_USER = 1;
  LABEL_AUTO = 2;
}

[emarkk]

Ok, my bad. It was just a cache issue. Works fine with v7. Thanks a lot!