feat: allow message.getTypeUrl provide custom typeUrlPrefix#1762
Merged
alexander-fenster merged 3 commits intoprotobufjs:masterfrom Jul 7, 2022
Merged
feat: allow message.getTypeUrl provide custom typeUrlPrefix#1762alexander-fenster merged 3 commits intoprotobufjs:masterfrom
alexander-fenster merged 3 commits intoprotobufjs:masterfrom
Conversation
alexander-fenster
changed the title
alexander-fenster
approved these changes
Jul 7, 2022
Contributor
alexander-fenster
left a comment
alexander-fenster
left a comment
There was a problem hiding this comment.
Thank you! Now that we have some test coverage for CLI tools, I added a test (and regenerated part of the test files which was generated, so this added some extra files to this PR).
This was referenced Jul 7, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in many other language implementations (such as Java, CSharp), Google provides optional parameter
typeUrlPrefixfor the functionpackorgetTypeUrlthis pr is a re-request of #1665 , the original pr was mistakenly overwritten by the force push of the pull bot