Skip to content

fix: do not let setProperty change the prototype #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-fenster merged 2 commits into from
Jun 23, 2023
+10 −1
Merged

fix: do not let setProperty change the prototype #1899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
709a262
fix: do not let setProperty change the prototype
alexander-fenster Jun 23, 2023
7eaa7d0
test: add unit test
alexander-fenster Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ util.decorateEnum = function decorateEnum(object) {
util.setProperty = function setProperty(dst, path, value) {
function setProp(dst, path, value) {
var part = path.shift();
if (part === "__proto__") {
if (part === "__proto__" || part === "prototype") {
Comment thread
alexander-fenster marked this conversation as resolved.
return dst;
}
if (path.length > 0) {
Expand Down
9 changes: 9 additions & 0 deletions tests/api_util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,15 @@ tape.test("util", function(test) {

util.setProperty(o, 'prop.subprop', { subsub2: 7});
test.same(o, {prop1: [5, 6], prop: {subprop: [{subsub: [5,6]}, {subsub2: 7}]}}, "should convert nested properties to array");

util.setProperty({}, "__proto__.test", "value");
test.is({}.test, undefined);

util.setProperty({}, "prototype.test", "value");
test.is({}.test, undefined);

util.setProperty({}, "constructor.prototype.test", "value");
test.is({}.test, undefined);

test.end();
});
Expand Down
⚡