feat!: add Edition 2024 Support#2060
Merged
mkruskal-google merged 2 commits intoprotobufjs:masterfrom Dec 16, 2025
Merged
Conversation
c683d48 to
2c387bd
Compare
sofisl
reviewed
Dec 11, 2025
Contributor
sofisl
left a comment
There was a problem hiding this comment.
My biggest question is, why are we deleting 2023 defaults? Can't protos specify what edition version they're going to use?
Contributor
Author
|
We're not deleting 2023 defaults, we're just adding 2024 ones |
sofisl
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic edition 2024 support in preparation for our upcoming 32.0 release. This is not completely finalized yet, and this PR will likely be held off until closer to the release date.
Edition 2024 only adds 2 new global features, and two grammar changes: