add the support to Long string #508#509
Closed
dreamershl wants to merge 6 commits intoprotobufjs:masterfrom
Closed
add the support to Long string #508#509dreamershl wants to merge 6 commits intoprotobufjs:masterfrom
dreamershl wants to merge 6 commits intoprotobufjs:masterfrom
Conversation
add string support to fix the protobufjs#508
Member
|
This is working now. Note, though, that always converting hence and forth between longs and strings is slow. Ideally, when encoding a message multiple times, the value should be present as a long instead of a string to prevent multiple conversions. |
Author
|
Thank u very much. the converting is only done when send/receive the message from the server in my system. So it should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.