Fix directly using Buffer instead of util.Buffer#571
Merged
dcodeIO merged 1 commit intoprotobufjs:masterfrom Dec 18, 2016
fnlctrl:patch-2
Merged
Fix directly using Buffer instead of util.Buffer#571dcodeIO merged 1 commit intoprotobufjs:masterfrom fnlctrl:patch-2
dcodeIO merged 1 commit intoprotobufjs:masterfrom
fnlctrl:patch-2
Conversation
This seems to have caused webpack to load a Buffer shim.
Member
|
Thanks! |
Member
|
Btw, doesn't this cause the same? |
Contributor
Author
|
Yes, this PR didn't solve the problem, and I forgot to leave a comment here. plugins: [
new webpack.IgnorePlugin(/^long$/),
new webpack.IgnorePlugin(/^buffer$/)
] |
dcodeIO
added a commit
that referenced
this pull request
Dec 18, 2016
Member
|
This now uses a dynamic require for all optional modules including buffer and long. Give it a shot! |
Contributor
Author
|
Works like a charm! Thanks for the awesome work! 👍👍👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to have caused webpack to load a Buffer shim when building for web.