Run update_file_lists.sh#8789
Closed
nipunn1313 wants to merge 1 commit intoprotocolbuffers:masterfrom
Closed
Conversation
Confirmed it worked via bazel test //:build_files_updated_unittest
Contributor
Author
|
Please apply labels "Release notes: no" and "cmake" for the relevant area (I think) Likely something slipped through the cracks allowing the master branch to be red - so it may be wise to follow up on what allowed that through. |
Contributor
Author
|
may want to consider updating the repository settings to allow workflow runs for outside contributors There appears to be settings for "require approval for first time contributors" and a looser setting for "require approval for first time contributors new to github". The latter might avoid this kind of headache for folks like me - so I can proactively make sure tests pass. |
Contributor
Author
|
going to abandon this - feel free to reopen if it seems useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Confirmed it worked via (previously failing)