Bring in SDK changes up to v0.50.7 and Mark v0.50.7-pio-1. by SpicyLemon · Pull Request #610 · provenance-io/cosmos-sdk

SpicyLemon · 2024-06-06T21:16:35Z

Description

This PR merges SDK v0.50.7 into our customized release-pio/v0.50.x branch.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

) (cosmos#19745) Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>

…osmos#19751) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

…mos#19759) (cosmos#19773) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

…9706) (cosmos#19767) Co-authored-by: Richard Gibson <richard.gibson@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

…9777) Co-authored-by: Julien Robert <julien@rbrt.fr>

…cosmos#19770) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cool Developer <cool199966@outlook.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

…osmos#19811) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

…osmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

…mos#19853) (cosmos#19859) Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: Julien Robert <julien@rbrt.fr>

…osmos#19870) (cosmos#19887)

…s#19884) Co-authored-by: Julien Robert <julien@rbrt.fr>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

…osmos#19925)

…19985) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <julien@rbrt.fr>

…osmos#20008) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

…#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

…osmos#20028) (cosmos#20029) Co-authored-by: mmsqe <mavis@crypto.com>

…s#20027) (cosmos#20031) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>

…s#20033) (cosmos#20046) Co-authored-by: mmsqe <mavis@crypto.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

…s#20014) (cosmos#20024)

…osmos#19616) (cosmos#20050)

) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>

… 1.0.0-beta.5 (cosmos#20095)

cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <julien@rbrt.fr>

…mos#20111) Co-authored-by: mmsqe <mavis@crypto.com>

…t (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

…ort cosmos#20144) (cosmos#20251) Co-authored-by: Marko <marko@baricevic.me>

…kport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <j@letey.de> Co-authored-by: Julien Robert <julien@rbrt.fr>

…20261) (cosmos#20327) Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com>

) (cosmos#20329) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

cosmos#20330) (cosmos#20340)

cosmos#20357)

) (cosmos#20366) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

…ckport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

…(backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

…smos#20460) Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

…#20459) Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com>

Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com>

Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>

Co-authored-by: Marko <marko@baricevic.me>

Release v0.50.7 # -----BEGIN PGP SIGNATURE----- # # iHUEABYKAB0WIQQQT/CpGzc0x0Rg2OeuqMIeYI8dAgUCZl7eUAAKCRCuqMIeYI8d # AtSlAQDNDwdITCbVickPmwEE/jJWDCY+we8wsv+mtMXE7WLchwD/cNu3kNleerWh # mre/fa+vON+1BHNMQuYrwJBbggcJEg8= # =o7IA # -----END PGP SIGNATURE----- # gpg: Signature made Tue Jun 4 03:28:48 2024 MDT # gpg: using EDDSA key 104FF0A91B3734C74460D8E7AEA8C21E608F1D02 # gpg: Can't check signature: No public key # Conflicts: # baseapp/baseapp.go

SpicyLemon · 2024-06-10T21:47:50Z

I ran the following make targets locally and they all completed successfully:

make test
make test-sim-nondeterminism
make test-sim-import-export
make test-sim-after-import
make test-sim-multi-seed-short

iramiller · 2024-06-10T23:43:35Z

+  };
+
+  rpc Clawback(MsgClawbackRequest) returns (MsgClawbackResponse) {
+    option (cosmos_proto.method_added_in) = "cosmos-sdk v0.51.0";


how is this added in 0.51 if we are still in 0.50.7? These "added in" comments are not a great idea...

iramiller

The SDK team adding the "since version" stuff isn't a great pattern but as we are getting this from upstream it is what it is. The changes to the bank restrictions should be closely reviewed given the comments about bypassing module sourced transfers ... largely this should be ok as we had a long list of "special" accounts that wouldn't be restricted from these (and the sanction/quarantine functions too).

mergify Bot and others added 30 commits March 14, 2024 02:59

fix(crypto): error if incorrect ledger public key (backport cosmos#19691

b8659ae

) (cosmos#19745) Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>

fix: align signer extraction adapter for mempool remove (backport cos…

9a59234

…mos#19759) (cosmos#19773) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

fix(x/upgrade): Stop treating inline JSON as a URL (backport cosmos#1…

0df2902

…9706) (cosmos#19767) Co-authored-by: Richard Gibson <richard.gibson@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

fix(client/v2): fix comment parsing (backport cosmos#19377) (cosmos#1…

1ad7fad

…9777) Co-authored-by: Julien Robert <julien@rbrt.fr>

chore(store): add release date (cosmos#19797)

a6c7aa5

feat(x/gov): emit proposer address in submit proposal event (backport c…

a0faab3

…osmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

feat(x/gov): emit depositor in proposal_deposit event (backport cos…

9c53142

…mos#19853) (cosmos#19859) Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: Julien Robert <julien@rbrt.fr>

reuse fromAddrString (minor cleanup) (cosmos#19881)

d78edac

feat(client): replace event-query-tx-for with wait-tx (backport c…

8641cd2

…osmos#19870) (cosmos#19887)

feat(server): add custom start handler (backport cosmos#19854) (cosmo…

7b35e36

…s#19884) Co-authored-by: Julien Robert <julien@rbrt.fr>

docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (c…

f63e5fd

…osmos#19925)

fix(client/v2): add encoder for cosmos.base.v1beta1.DecCoin (backport

525b720

cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <julien@rbrt.fr>

fix(mempool): use no-op mempool as default (backport cosmos#19970) (c…

f76c659

…osmos#20008) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

feat: Conditionally emit metrics based on enablement (backport cosmos…

974a24c

…#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

fix(x/bank): align query with multi denoms for send-enabled (backport c…

452632f

…osmos#20028) (cosmos#20029) Co-authored-by: mmsqe <mavis@crypto.com>

fix: Implement gogoproto customtype to secp256r1 keys (backport cosmo…

521ebe5

…s#20027) (cosmos#20031) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>

fix(client/v2): respect output format from client ctx (backport cosmo…

741b01c

…s#20033) (cosmos#20046) Co-authored-by: mmsqe <mavis@crypto.com>

feat(x/bank): support depinject for send restrictions (backport cosmo…

dafcc78

…s#20014) (cosmos#20024)

fix(baseapp): don't share global gas meter in tx execution (backport c…

9941498

…osmos#19616) (cosmos#20050)

fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069

49c3ae6

) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>

build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to…

a2abf1a

… 1.0.0-beta.5 (cosmos#20095)

feat(client/v2): implement version filtering using annotation (backport

2a32f42

cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <julien@rbrt.fr>

chore: prepare v0.50.6 (cosmos#19998)

4bd0e02

fix: use timestamp for sim log file name (backport cosmos#20108) (cos…

0a682f7

…mos#20111) Co-authored-by: mmsqe <mavis@crypto.com>

mergify Bot and others added 21 commits April 29, 2024 14:07

fix: remove txs from mempool when antehandler fails in recheck (backp…

8ffc807

…ort cosmos#20144) (cosmos#20251) Co-authored-by: Marko <marko@baricevic.me>

feat(baseapp): expose grpc query router via depinject. (cosmos#20264)

bd886bb

feat(client/v2): override short description in generated command (bac…

a2d3b2a

…kport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <j@letey.de> Co-authored-by: Julien Robert <julien@rbrt.fr>

feat(runtime): Add missing NewTransientStoreService (backport cosmos#…

9f8e3a5

…20261) (cosmos#20327) Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com>

fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323

3904228

) (cosmos#20329) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

fix(client/v2): correctly check subcommand short descriptions (backport

5d5e2d0

cosmos#20330) (cosmos#20340)

build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338)

b696f7a

style: Fix gov query proposals examples syntax (backport cosmos#20353) (

5b6045c

cosmos#20357)

feat(client): add consensus address for debug cmd (backport cosmos#20328

08fdfec

) (cosmos#20366) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

feat(client): overwrite client context instead of setting new one (ba…

83747c5

…ckport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

fix: correctly assign execModeSimulate to context for simulateTx …

b99ca2c

…(backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

docs: update diagram to be shown properly (backport cosmos#20454) (co…

2ca9873

…smos#20460) Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

docs: fix note blocks display failure (backport cosmos#20457) (cosmos…

5545d45

…#20459) Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com>

docs: update link contents (backport cosmos#20437) (cosmos#20462)

443f153

Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com>

fix(x/consensus): harden consensus params proposal (cosmos#20381)

d180df8

Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>

docs: add docs on permissions (backport cosmos#20526) (cosmos#20527)

9cfb349

Co-authored-by: Marko <marko@baricevic.me>

chore(x/upgrade): bump vulnerable go-getter library (cosmos#20530)

9313b0f

chore: prepare v0.50.7 (cosmos#20475)

62212df

Add changelog entry and mark v0.50.7-pio-1 in the changelog.

6e96935

SpicyLemon marked this pull request as ready for review June 7, 2024 01:30

Fix the release date of v0.50.7-pio-1.

8c1f6cf

SpicyLemon changed the title ~~Bring in SDK changes up to v0.50.7~~ Bring in SDK changes up to v0.50.7 and Mark v0.50.7-pio-1. Jun 10, 2024

SpicyLemon enabled auto-merge (squash) June 10, 2024 22:47

iramiller reviewed Jun 10, 2024

View reviewed changes

iramiller approved these changes Jun 10, 2024

View reviewed changes

SpicyLemon merged commit 8e14244 into release-pio/v0.50.x Jun 10, 2024

SpicyLemon deleted the prov/dwedul/bump-to-v0.50.7 branch December 17, 2024 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring in SDK changes up to v0.50.7 and Mark v0.50.7-pio-1.#610

Bring in SDK changes up to v0.50.7 and Mark v0.50.7-pio-1.#610
SpicyLemon merged 63 commits into
release-pio/v0.50.xfrom
prov/dwedul/bump-to-v0.50.7

SpicyLemon commented Jun 6, 2024 •

edited

Loading

Uh oh!

SpicyLemon commented Jun 10, 2024

Uh oh!

iramiller Jun 10, 2024 •

edited

Loading

Uh oh!

iramiller left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

SpicyLemon commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Author Checklist

Reviewers Checklist

Uh oh!

SpicyLemon commented Jun 10, 2024

Uh oh!

iramiller Jun 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iramiller left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SpicyLemon commented Jun 6, 2024 •

edited

Loading

iramiller Jun 10, 2024 •

edited

Loading