[Feature Request] Support CONNECT handlers

[SentryMan]

I was thinking of intercepting the CONNECT method and throwing 403 in cases like authentication failing (particularly for preventing upgrades to webtransport).

[SentryMan]

Is this something you're interested in? I can make a PR if you so desire.

[ptrd]

Yeah, could be a good addition. Can you give an outline / sketch of the intended change? So we can discuss before you create the PR ...

[SentryMan]

The middleware I have on top of flupke currently can only operate with the registered handler, so the easy solution is reuse the existing registered handler and call it here before we do the connect extended handling.

flupke/core/src/main/java/tech/kwik/flupke/server/impl/Http3ServerConnectionImpl.java

Line 153 in 31f1915

private void handleConnectMethod(QuicStream quicStream, HeadersFrame headersFrame) {

and if the request was closed or the status sent we don't do any extended handling.

Alternatively, we could create a second handler specifically for CONNECT purposes instead of the registered handler.

[SentryMan]

any thoughts on this?

[ptrd]

I'm not exactly sure what you mean with "reuse the existing registered handler", but if you mean that on receiving a CONNECT request the server should call the normal HttpRequestHandler.handleRequest method to let the handler decide on whether or not to accept the CONNECT request (2xx is accept, anything else is deny), then I agree ;-).

[SentryMan]

then we are of one mind, I'll raise a PR

[ptrd]

merged to master
Thanks @SentryMan !

[SentryMan]

Most excellent, thanks for your time. Perchance when do you think it can be deployed?

[ptrd]

Yeah, i'll create a new release soon, i.e. within a few days, maybe today.

[SentryMan]

Legend