Skip to content

fix: badges can grow #10005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BF150 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: badges can grow #10005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69b1e4d
removed inline so the badge grows
BF150 Apr 13, 2026
ffc1506
Update all snapshots
BF150 Apr 13, 2026
aae22ef
removed theme styles
BF150 Apr 13, 2026
710188e
Update all snapshots
BF150 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/components/src/components/badge/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
.kol-badge {
/* Visible with forced colors */
outline: transparent solid to-rem(1);
display: inline-flex;
place-items: center;
display: flex;
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changing display: inline-flex to display: flex makes the badge a block-level element. This causes the component to occupy the full width of its container and start on a new line, which is typically not the expected behavior for a badge. Badges are generally expected to be inline elements. If the goal is to allow the badge to grow in certain contexts, it is recommended to keep inline-flex and manage the growth via the host element's styling (e.g., flex-grow or width) in the parent layout.

Suggested change
display: flex;
display: inline-flex;

align-items: center;
justify-content: space-between;

.kol-badge__smart-button {
.button {
Expand Down
Binary file modified ...me-bwst/snapshot-for-scenarios-focus-elements-component-badge-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/themes/bwst/snapshots/theme-bwst/snapshot-for-version-basic-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion packages/themes/bwst/src/components/badge.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
@include kol-icon-theme;
.kol-badge {
border-radius: var(--border-radius);
display: inline-flex;
font-style: normal;

&--has-smart-button {
Expand Down
Binary file modified ...default/snapshot-for-scenarios-focus-elements-component-badge-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...es/default/snapshots/theme-default/snapshot-for-version-basic-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion packages/themes/default/src/components/badge.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
@include kol-icon-theme;
.kol-badge {
border-radius: var(--border-radius);
display: inline-flex;
font-style: normal;

&--has-smart-button {
Expand Down
Binary file modified ...kern_v2/snapshot-for-scenarios-focus-elements-component-badge-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...hemes/kern/snapshots/theme-kern_v2/snapshot-for-version-basic-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
⚡