Skip to content

Add text input for hex value to kol-input-color#7446

Merged
deleonio merged 3 commits intodevelopfrom
7164_input-color-styling
Mar 14, 2025
Merged

Add text input for hex value to kol-input-color#7446
deleonio merged 3 commits intodevelopfrom
7164_input-color-styling

Conversation

@anicyne
Copy link
Copy Markdown
Contributor

@anicyne anicyne commented Mar 7, 2025

Refs: #7164

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@anicyne anicyne linked an issue Mar 7, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laske185, @cbraehmig lasst uns dazu noch einmal sprechen.

@deleonio
Copy link
Copy Markdown
Contributor

deleonio commented Mar 12, 2025

Hallo @anicyne,

ich wollte eigentlich den Code kommentieren, doch die Punkte die wir verbessern wollen, kann ich dort leider nicht wiederfinden. Daher hier unsere Anforderungen:

  • id's dürfen immer nur 1 mal pro DOM gesetzt sein. Also beim Color-Input weg. Das Label darf nur mit dem Input-Text über for und id verknüpft sein.
  • Die datalist darf nur 1 mal drin sein. Muss aber sowohl beim Color- als auch Text-Input verwendet werden.
  • Das Color-Input braucht flex-grow: 1, Das Text-Input soll nur 7 Zeichen breit sein.
  • Das Text-Input soll initial den Wert aus dem Color-Input anzeigen, wenn nix explizit gesetzt wurde.

@anicyne anicyne force-pushed the 7164_input-color-styling branch from dab750b to 3cdf1bf Compare March 12, 2025 15:02
@anicyne anicyne requested a review from deleonio March 12, 2025 15:14
@deleonio deleonio merged commit 38bbc9f into develop Mar 14, 2025
9 checks passed
@deleonio deleonio deleted the 7164_input-color-styling branch March 14, 2025 12:42
@publicuibot publicuibot bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9.1.1.1a - input-color: Alternativtexte für Bedienelemente

2 participants