Conversation
deleonio
changed the title
Contributor
|
Netlify Draft Deployment |
$ Refs: #7460
sdvg
approved these changes
Mar 12, 2025
laske185
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the GitHub Actions workflows and some improvements to the visual tests. The most important changes involve updating Node.js and pnpm versions across multiple workflow files, adding new input parameters for snapshot updates, and refactoring the visual tests to use default snapshot options.
Updates to GitHub Actions workflows:
.github/actions/pnpm-setup/action.yml: Updated pnpm version from 9 to 10..github/workflows/auto-dependency-updater.yml: Updated Node.js version from 20 to 22 and pnpm version from 9 to 10..github/workflows/draft-deploy.yml: Updated Node.js version from 20 to 22 and pnpm version from 9 to 10..github/workflows/publish.yml: Updated Node.js version from 20 to 22 and pnpm version from 9 to 10. [1] [2].github/workflows/test-deploy.yml: Updated Node.js version from 20 to 22 and pnpm version from 9 to 10.Enhancements to snapshot update workflow:
.github/workflows/update-snapshots.yml: Addeddelete_snapshotsinput parameter to optionally delete existing snapshots before updating. Updated Node.js version from 20 to 22 and pnpm version from 9 to 10. [1] [2] [3]Improvements to visual tests:
packages/tools/visual-tests/tests/theme-snapshots.spec.js: IntroducedDEFAULT_SNAPSHOT_OPTIONSto standardize snapshot options and refactored existing tests to use these default options. [1] [2]Refs: #7460
The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer: