Skip to content

feat: add stylelint configuration and update package.json for SCSS linting#7587

Merged
deleonio merged 1 commit intodevelopfrom
7537-add-stylelint-v3
May 7, 2025
Merged

feat: add stylelint configuration and update package.json for SCSS linting#7587
deleonio merged 1 commit intodevelopfrom
7537-add-stylelint-v3

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

@deleonio deleonio commented Apr 23, 2025

This pull request introduces Stylelint integration across various packages in the project to enforce CSS and SCSS code quality standards. It also removes the ts-prune dependency and related scripts from the project. Below are the key changes grouped by theme:

Stylelint Integration:

  • Added Stylelint configuration files (.stylelintrc.json) to multiple packages, including components, samples/react, and themes (bwst, default, ecl, and itzbund). These configurations extend stylelint-config-standard and stylelint-config-recommended-scss and include rules for SCSS best practices.
  • Updated lint scripts in package.json files of affected packages to include Stylelint checks for CSS and SCSS files. [1] [2] [3] [4]
  • Added Stylelint dependencies (stylelint, stylelint-config-standard, stylelint-config-recommended-scss, and stylelint-scss) to the package.json files of relevant packages. [1] [2] [3] [4]
  • Updated .stylelintignore in the components package to exclude src/assets/.

Dependency Cleanup:

  • Removed the ts-prune dependency and associated scripts from the root package.json. This includes the removal of the ts-prune script and its invocation in the lint workflow. [1] [2]

Development Environment:

  • Updated .vscode/settings.json to enable Stylelint validation for CSS, SCSS, Sass, and Less files.…ting

Refs: #7537

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio added the v3 label Apr 23, 2025
@deleonio deleonio linked an issue Apr 23, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 23, 2025

Netlify Draft Deployment
URL:
Logs:

@deleonio deleonio force-pushed the 7537-add-stylelint-v3 branch from 02aa279 to d5b0045 Compare May 6, 2025 03:27
@deleonio deleonio marked this pull request as draft May 6, 2025 04:56
@deleonio deleonio force-pushed the 7537-add-stylelint-v3 branch from 8846f28 to 39828ad Compare May 6, 2025 22:36
@deleonio deleonio marked this pull request as ready for review May 7, 2025 05:41
@deleonio deleonio merged commit 52d7220 into develop May 7, 2025
9 checks passed
@deleonio deleonio deleted the 7537-add-stylelint-v3 branch May 7, 2025 05:41
@publicuibot publicuibot bot locked and limited conversation to collaborators May 7, 2025
@deleonio deleonio removed the v3 label Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stylelint in PublicUI-Kolibri integrieren

1 participant