Conversation
Contributor
|
Netlify Draft Deployment |
…able-settings * origin/1834-table-settings: (25 commits) Update all snapshots$ $ Refs: #7627 fix: update layout classes for better responsiveness in various components fix: update layout classes for better responsiveness in ChangeTabindex component fix: wrap terms acceptance text in a span for better structure fix: update grid classes for responsive design in SampleDescription and HandoutBasic components Fix duplicate aria-labels for pagination Add combobox and single-single E2E tests fix: refactor SampleDescription component and update documentation links Make git revision parsing fail-safe Fix: Dropdown opens on input click ( Combobox und SingleSelect) Update all snapshots$ $ Refs: #7594 refactor: remove badge-text-hint mixin and styles from components feat: add padding and border-radius to badge-text-hint styles fix: improve environment variable handling in Playwright config fix: adjust spacing and color for button styles feat: add background to short and access key badge at buttons fix: underline only the text of a tree item Update all snapshots$ $ Refs: #7583 Fix toggle button styling Replace Toggle Button in nav with KolButtonWc ...
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds table settings functionality to both stateless and stateful table components, allowing users to adjust column visibility, order, and width. Key changes include adding new prop types and localization strings for table settings and integrating the settings UI along with related event handling and tests.
Reviewed Changes
Copilot reviewed 74 out of 82 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/schema/components/tableStateless.ts | Added table settings type to optional props and states. |
| packages/components/src/schema/components/table.ts | Added table settings type to optional props and states in stateful components. |
| packages/components/src/locales/{en,de}.ts | Introduced new localization keys for table settings. |
| packages/components/src/core/component-names.ts | Registered new custom element tag for table settings. |
| packages/components/src/components/table-stateless/table-settings.tsx | Implemented table settings UI and corresponding behavior. |
| packages/components/src/components/table-stateless/component.tsx | Integrated table settings into table rendering logic and settings initialization. |
| packages/components/src/components/table-stateful/shadow.tsx | Passed table settings down to stateful table components. |
| packages/components/src/components/popover-button/* | Updated popover-button components to support new requirements. |
Files not reviewed (8)
- packages/components/src/components/@shared/_kol-popover-button-mixin.scss: Language not supported
- packages/components/src/components/@shared/_kol-table-settings-mixin.scss: Language not supported
- packages/components/src/components/@shared/_kol-table-stateless-mixin.scss: Language not supported
- packages/components/src/components/popover-button/style.scss: Language not supported
- packages/components/src/components/popover-button/test/snapshots/snapshot.spec.tsx.snap: Language not supported
- packages/components/src/components/table-stateful/style.scss: Language not supported
- packages/components/src/components/table-stateless/style.scss: Language not supported
- packages/components/src/components/table-stateless/test/snapshots/snapshot.spec.tsx.snap: Language not supported
Comments suppressed due to low confidence (1)
packages/components/src/components/table-stateless/component.tsx:610
- [nitpick] Instead of returning an empty string to skip rendering invisible columns, consider returning null. This more explicitly indicates that no element should be rendered and improves readability.
if (columnSetting && !columnSetting.visible) { return ''; }
deleonio
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #1834
The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer: