Skip to content

fix: update layout classes for better responsiveness#7633

Merged
laske185 merged 2 commits intorelease/2from
7627-v2
May 5, 2025
Merged

fix: update layout classes for better responsiveness#7633
laske185 merged 2 commits intorelease/2from
7627-v2

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

@deleonio deleonio commented May 4, 2025

This pull request focuses on improving the layout and spacing of components in the sample React application by standardizing the use of flexbox and adjusting gaps between elements. Additionally, it includes a minor cleanup in the SCSS file to simplify styles.

Layout and Spacing Improvements:

  • Updated the className for multiple components (BadgeBasic, BadgeButton, ButtonBaselined, LinkButtonBasic, LinkButtonAriaDescription, and TreeBasic) to use flex-wrap for better responsiveness and standardized the gap to gap-2 for consistent spacing. ([[1]](https://github.com/public-ui/kolibri/pull/7633/files#diff-d85848d22d4faf68f0cfd092de17ed5d399a9b772b3533455321db6d091eb014L14-R14), [[2]](https://github.com/public-ui/kolibri/pull/7633/files#diff-010e71cf88e49cac26861851a9228bebd9d82e094dcc06c11a6050af019fd943L26-R26), [[3]](https://github.com/public-ui/kolibri/pull/7633/files#diff-07f660ca3914d46f74147095df90ea6894b81fb6199807486268b645e28e8579L22-R22), [[4]](https://github.com/public-ui/kolibri/pull/7633/files#diff-00a8156da06c8ab0465785121dc6a1402d3d99b4d95f893a1a23bd65cdf7798dL12-R12), [[5]](https://github.com/public-ui/kolibri/pull/7633/files#diff-9b39568738781c75bc616f66afacfe58c9545290cbb027b740d65c5fa566829eL18-R18), [[6]](https://github.com/public-ui/kolibri/pull/7633/files#diff-5c58b88d230486003f8ba7cd90c40594113dd401e30ae278b5ee0be2b036bee1L69-R69))

SCSS Cleanup:

  • Removed unused and redundant styles in the .indented-text class, simplifying the CSS by eliminating custom font-family, borders, and padding. ([packages/samples/react/src/style.scssL26-R26](https://github.com/public-ui/kolibri/pull/7633/files#diff-77946dd577afaf41b953d8977fd290a288d7e1a862ebb193211525c7fd9c1a51L26-R26))

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio added the v2 label May 4, 2025
@deleonio deleonio linked an issue May 4, 2025 that may be closed by this pull request
4 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 4, 2025

@deleonio deleonio requested a review from laske185 May 5, 2025 04:45
@laske185 laske185 merged commit 6943f75 into release/2 May 5, 2025
8 of 9 checks passed
@laske185 laske185 deleted the 7627-v2 branch May 5, 2025 06:54
@publicuibot publicuibot bot locked and limited conversation to collaborators May 5, 2025
@deleonio deleonio removed the v2 label Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobilansicht Sample-App optimieren

2 participants