Conversation
4 tasks
Contributor
|
Netlify Draft Deployment |
$ Refs: #7627
laske185
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the layout and spacing of components in the sample React application by standardizing the use of flexbox and adjusting gaps between elements. Additionally, it includes a minor cleanup in the SCSS file to simplify styles.
Layout and Spacing Improvements:
classNamefor multiple components (BadgeBasic,BadgeButton,ButtonBaselined,LinkButtonBasic,LinkButtonAriaDescription, andTreeBasic) to useflex-wrapfor better responsiveness and standardized the gap togap-2for consistent spacing. ([[1]](https://github.com/public-ui/kolibri/pull/7633/files#diff-d85848d22d4faf68f0cfd092de17ed5d399a9b772b3533455321db6d091eb014L14-R14),[[2]](https://github.com/public-ui/kolibri/pull/7633/files#diff-010e71cf88e49cac26861851a9228bebd9d82e094dcc06c11a6050af019fd943L26-R26),[[3]](https://github.com/public-ui/kolibri/pull/7633/files#diff-07f660ca3914d46f74147095df90ea6894b81fb6199807486268b645e28e8579L22-R22),[[4]](https://github.com/public-ui/kolibri/pull/7633/files#diff-00a8156da06c8ab0465785121dc6a1402d3d99b4d95f893a1a23bd65cdf7798dL12-R12),[[5]](https://github.com/public-ui/kolibri/pull/7633/files#diff-9b39568738781c75bc616f66afacfe58c9545290cbb027b740d65c5fa566829eL18-R18),[[6]](https://github.com/public-ui/kolibri/pull/7633/files#diff-5c58b88d230486003f8ba7cd90c40594113dd401e30ae278b5ee0be2b036bee1L69-R69))SCSS Cleanup:
.indented-textclass, simplifying the CSS by eliminating custom font-family, borders, and padding. ([packages/samples/react/src/style.scssL26-R26](https://github.com/public-ui/kolibri/pull/7633/files#diff-77946dd577afaf41b953d8977fd290a288d7e1a862ebb193211525c7fd9c1a51L26-R26))The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer: