Skip to content

Fix drawer content not expanding properly #7638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deleonio merged 2 commits into from
May 7, 2025
Merged

Fix drawer content not expanding properly #7638

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0563d6
fix: enhance drawer component styles for better layout and responsive…
deleonio May 7, 2025
5380064
Update all snapshots$
deleonio May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/components/src/components/drawer/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

@layer kol-component {
.kol-drawer {
$root: &;
font-size: rem(16);

&__dialog {
Expand All @@ -21,27 +22,43 @@
left: 0;
height: 100vh;
max-height: 100%;

#{$root}__content {
height: 100%;
}
}

&--right {
top: 0;
right: 0;
height: 100vh;
max-height: 100%;

#{$root}__content {
height: 100%;
}
}

&--top {
left: 0;
top: 0;
width: 100vw;
max-width: 100%;

#{$root}__content {
width: 100%;
}
}

&--bottom {
left: 0;
bottom: 0;
width: 100vw;
max-width: 100%;

#{$root}__content {
width: 100%;
}
}
}

Expand Down
12 changes: 7 additions & 5 deletions packages/samples/react/src/components/drawer/basic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ export const DrawerBasic: FC = () => {
<DrawerRadioAlign value={align} onChange={(_, value) => setAlign(value as AlignPropType)} />
<div className="flex flex-wrap gap-4">
<KolDrawer ref={drawerElement} _label="I am a drawer" _align={align} _on={{ onClose: () => console.log('Drawer onClose triggered!') }}>
<p>
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam
voluptua.
</p>
<KolButton _label="Close drawer" _on={{ onClick: () => drawerElement.current?.close() }} />
<div className={align === 'left' || align == 'right' ? 'drawer-content-vertical' : ''}>
<p>
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam
voluptua.
</p>
<KolButton _label="Close drawer" _on={{ onClick: () => drawerElement.current?.close() }} />
</div>
</KolDrawer>
<KolButton _label="Open drawer" _on={{ onClick: () => drawerElement.current?.open() }} />
</div>
Expand Down
6 changes: 5 additions & 1 deletion packages/samples/react/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ hr {
width: 500px;
}

.drawer-content-vertical {
width: rem(400);
}

@media (min-width: 1024px) {
.app-container {
display: grid;
Expand Down Expand Up @@ -84,4 +88,4 @@ hr {
.no-print * {
display: none !important;
}
}
}
Loading
⚡