Skip to content

Enhance DoD workflow to include 'ready_for_review' event#7676

Merged
deleonio merged 1 commit intorelease/2from
7675-v2
May 9, 2025
Merged

Enhance DoD workflow to include 'ready_for_review' event#7676
deleonio merged 1 commit intorelease/2from
7675-v2

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

@deleonio deleonio commented May 9, 2025

This pull request updates the .github/workflows/dod-checker.yml file to enhance the behavior of the "Definition of Done" workflow by adding a new trigger and improving conditional execution.

Workflow improvements:

  • Added the ready_for_review event type to the pull_request trigger, ensuring the workflow runs when a draft pull request is marked as ready for review.
  • Introduced a conditional check to skip the check-dod job if the pull request is still in draft status, optimizing workflow execution.

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio added the v2 label May 9, 2025
@deleonio deleonio marked this pull request as draft May 9, 2025 03:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2025

Netlify Draft Deployment
URL:
Logs:

@deleonio deleonio marked this pull request as ready for review May 9, 2025 03:24
@deleonio deleonio requested a review from Copilot May 9, 2025 03:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Definition of Done workflow by adding a new trigger event and a conditional check to optimize execution.

  • Added the ready_for_review event to the pull_request trigger, ensuring the workflow runs when a draft PR becomes ready for review.
  • Introduced a conditional check on the check-dod job to run only when the pull request is not in draft status.

Comment thread .github/workflows/dod-checker.yml
@deleonio deleonio merged commit ce31f81 into release/2 May 9, 2025
7 of 8 checks passed
@deleonio deleonio deleted the 7675-v2 branch May 9, 2025 03:27
@publicuibot publicuibot bot locked and limited conversation to collaborators May 9, 2025
@deleonio deleonio removed the v2 label Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants