Conversation
…d clarify draft PR handling Refs: #7675
Contributor
|
Netlify Draft Deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the "Definition of Done" (DoD) checklist and its associated GitHub Actions workflow to improve clarity and functionality. The most important changes include refining the DoD checklist items, adding a new trigger for the workflow, and enhancing the workflow to skip draft pull requests and use an updated runner.
Updates to the DoD checklist:
.github/dod.yml: Consolidated two checklist items into one by combining "Pull request is linked to an issue" and "All changes relate to the issue" for clarity. Removed redundant items like "Maturation completed and documented" and "No commented out code in the final commit."Improvements to the DoD workflow:
.github/workflows/dod-checker.yml: Addedready_for_reviewas a new trigger type to ensure the workflow runs when a draft pull request is marked as ready for review..github/workflows/dod-checker.yml: Updated the workflow to skip execution for draft pull requests by adding a conditional check..github/workflows/dod-checker.yml: Changed the runner fromubuntu-latesttoubuntu-24.04for consistency and to use a specific versionThe A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer: