Skip to content

Enhance DoD workflow to include 'ready_for_review' trigger#7678

Merged
deleonio merged 1 commit intorelease/1from
7675-v1
May 9, 2025
Merged

Enhance DoD workflow to include 'ready_for_review' trigger#7678
deleonio merged 1 commit intorelease/1from
7675-v1

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

@deleonio deleonio commented May 9, 2025

This pull request updates the "Definition of Done" (DoD) checklist and its associated GitHub Actions workflow to improve clarity and functionality. The most important changes include refining the DoD checklist items, adding a new trigger for the workflow, and enhancing the workflow to skip draft pull requests and use an updated runner.

Updates to the DoD checklist:

  • .github/dod.yml: Consolidated two checklist items into one by combining "Pull request is linked to an issue" and "All changes relate to the issue" for clarity. Removed redundant items like "Maturation completed and documented" and "No commented out code in the final commit."

Improvements to the DoD workflow:

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio added the v1 label May 9, 2025
@deleonio deleonio changed the title (#7675) Enhance DoD workflow to include 'ready_for_review' trigger an… (#7675) Enhance DoD workflow to include 'ready_for_review' trigger May 9, 2025
@deleonio deleonio changed the title (#7675) Enhance DoD workflow to include 'ready_for_review' trigger Enhance DoD workflow to include 'ready_for_review' trigger May 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2025

Netlify Draft Deployment
URL:
Logs:

@deleonio deleonio marked this pull request as ready for review May 9, 2025 08:44
@deleonio deleonio merged commit 22f4a3f into release/1 May 9, 2025
6 of 7 checks passed
@deleonio deleonio deleted the 7675-v1 branch May 9, 2025 08:44
@publicuibot publicuibot bot locked and limited conversation to collaborators May 9, 2025
@deleonio deleonio removed the v1 label Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOD - Quality-Gate nur, wenn PR im Review nicht wenn der PR im Draft ist

1 participant