Conversation
Contributor
|
Netlify Draft Deployment |
…ip unnecessary tests Refs: #7251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the visual testing logic in
theme-snapshots.spec.jsby introducing more granular control over snapshot options and skipping unnecessary tests. The changes improve test efficiency and maintainability by organizing snapshot-related configurations under asnapshotobject.Improvements to snapshot test logic:
Added conditional logic to skip unnecessary tests: Introduced checks to skip both normal and zoom snapshot tests if the
skipflag is set in thesnapshotconfiguration. This avoids running redundant tests. [1] [2]Refined viewport and timeout handling: Updated the code to pull
viewportSizeandwaitForTimeoutvalues from thesnapshotconfiguration, ensuring these settings are scoped specifically to snapshot-related options.Improved snapshot option merging: Replaced the direct use of
DEFAULT_SNAPSHOT_OPTIONSwith a newSNAPSHOT_OPTIONSobject that merges default options with specificsnapshot-scoped configurations. This makes the code more modular and easier to extend.Enhanced zoom test options: Added support for merging additional
zoom-specific options into the snapshot configuration, enabling more flexibility for zoom tests.The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer: