Skip to content

feat: Implement BEM structure for Alert and Icon components#7783

Merged
deleonio merged 3 commits intodevelopfrom
7778-add-typed-bem
Jun 2, 2025
Merged

feat: Implement BEM structure for Alert and Icon components#7783
deleonio merged 3 commits intodevelopfrom
7778-add-typed-bem

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

@deleonio deleonio commented May 27, 2025

  • Added BEM class generation for the kol-alert component, defining elements and modifiers.
  • Created a new bem.ts file for the kol-icon component to manage BEM class names.
  • Updated shadow.tsx and Alert.tsx to utilize BEM class names for styling.
  • Refactored Alert component to use dynamic BEM class names based on props.
  • Adjusted SCSS mixins and styles to align with the new BEM structure.
  • Updated snapshots to reflect changes in class names and structure.
  • Introduced a script to generate SCSS files based on BEM definitions.
  • Updated package dependencies to include typed-bem for BEM class generation.

Refs: #7778

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 27, 2025

@deleonio deleonio marked this pull request as draft May 27, 2025 01:19
@deleonio deleonio force-pushed the 7778-add-typed-bem branch from 7ced1bf to 4db0def Compare May 27, 2025 01:59
@deleonio deleonio requested a review from sdvg May 27, 2025 07:24
@deleonio deleonio force-pushed the 7778-add-typed-bem branch 13 times, most recently from ea14036 to 2b0e74d Compare June 1, 2025 20:54
@public-ui public-ui deleted a comment from github-actions bot Jun 1, 2025
@public-ui public-ui deleted a comment from github-actions bot Jun 1, 2025
@deleonio deleonio force-pushed the 7778-add-typed-bem branch 2 times, most recently from 6afd945 to 5ff4cf1 Compare June 1, 2025 22:11
@deleonio deleonio force-pushed the 7778-add-typed-bem branch from 5ff4cf1 to cf2a5f8 Compare June 1, 2025 22:16
@deleonio deleonio marked this pull request as ready for review June 2, 2025 06:47
@deleonio deleonio requested a review from laske185 June 2, 2025 06:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2025

Hydration Benchmark Report (vs Baseline)

📊 Top 5 Änderungen

Component Current Baseline Δ% Result
kol-heading 29ms 15ms +93.3% 🔻
kol-toolbar 13ms 7ms +85.7% 🔻
kol-breadcrumb 28ms 17ms +64.7% 🔻
kol-card 28ms 17ms +64.7% 🔻
kol-image 6ms 10ms -40.0%
📋 Alle Ergebnisse anzeigen
Component Current Baseline Δ% Result
kol-abbr 7ms 9ms -22.2%
kol-accordion 76ms 99ms -23.2%
kol-alert 30ms 23ms +30.4% 🔻
kol-avatar 12ms 10ms +20.0% 🔻
kol-badge 32ms 31ms +3.2%
kol-button 53ms 50ms +6.0% 🔻
kol-button-link 55ms 51ms +7.8% 🔻
kol-details 65ms 59ms +10.2% 🔻
kol-drawer 12ms 12ms 0.0%
kol-form 12ms 11ms +9.1% 🔻
kol-icon 11ms 10ms +10.0% 🔻
kol-input-checkbox 36ms 34ms +5.9% 🔻
kol-input-color 34ms 34ms 0.0%
kol-input-date 39ms 36ms +8.3% 🔻
kol-input-email 37ms 41ms -9.8%
kol-input-file 64ms 65ms -1.5%
kol-input-number 32ms 33ms -3.0%
kol-input-password 32ms 33ms -3.0%
kol-input-radio 33ms 30ms +10.0% 🔻
kol-input-text 38ms 44ms -13.6%
kol-link 56ms 45ms +24.4% 🔻
kol-link-button 49ms 47ms +4.3%
kol-modal 8ms 6ms +33.3% 🔻
kol-nav 11ms 11ms 0.0%
kol-pagination 75ms 67ms +11.9% 🔻
kol-popover-button 56ms 55ms +1.8%
kol-progress 8ms 9ms -11.1%
kol-quote 8ms 12ms -33.3%
kol-select 33ms 35ms -5.7%
kol-skip-nav 8ms 13ms -38.5%
kol-spin 6ms 9ms -33.3%
kol-split-button 58ms 57ms +1.8%
kol-table-stateful 82ms 79ms +3.8%
kol-table-stateless 86ms 80ms +7.5% 🔻
kol-tabs 12ms 9ms +33.3% 🔻
kol-textarea 31ms 29ms +6.9% 🔻
kol-tree 11ms 10ms +10.0% 🔻
kol-tree-item 60ms 48ms +25.0% 🔻
kol-version 56ms 47ms +19.1% 🔻

@deleonio deleonio merged commit 0e53a73 into develop Jun 2, 2025
10 checks passed
@deleonio deleonio deleted the 7778-add-typed-bem branch June 2, 2025 15:12
@publicuibot publicuibot bot locked and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant