Skip to content

Fix input-radio hitbox#7790

Merged
deleonio merged 18 commits intodevelopfrom
7303-fix-radio-hitbox
Jun 11, 2025
Merged

Fix input-radio hitbox#7790
deleonio merged 18 commits intodevelopfrom
7303-fix-radio-hitbox

Conversation

@anicyne
Copy link
Copy Markdown
Contributor

@anicyne anicyne commented May 28, 2025

Refs: #7303

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2025

@anicyne anicyne linked an issue May 28, 2025 that may be closed by this pull request
Comment thread .github/workflows/update-snapshots.yml
@deleonio deleonio requested review from deleonio and sdvg and removed request for deleonio June 2, 2025 07:37
deleonio
deleonio previously approved these changes Jun 2, 2025
Comment thread packages/components/src/components/input-radio/shadow.tsx Outdated
Comment thread packages/components/src/components/input-radio/shadow.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2025

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-tree 1.4ms 1.7ms -17.6%
kol-heading 0.8ms 0.9ms -11.1%
kol-input-number 1.3ms 1.4ms -7.1%
kol-badge 1.4ms 1.5ms -6.7%
kol-accordion 4.7ms 4.9ms -4.1%

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-input-email 1.6ms 1.3ms +23.1% 🔻
kol-image 0.8ms 0.7ms +14.3% 🔻
kol-select 1.7ms 1.5ms +13.3% 🔻
kol-modal 0.9ms 0.8ms +12.5% 🔻
kol-spin 0.9ms 0.8ms +12.5% 🔻
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 0.8ms 0.8ms 0%
kol-accordion 4.7ms 4.9ms -4.1%
kol-alert 3.8ms 3.8ms 0%
kol-avatar 1.3ms 1.3ms 0%
kol-badge 1.4ms 1.5ms -6.7%
kol-breadcrumb 2.8ms 2.7ms +3.7%
kol-button 2.6ms 2.7ms -3.7%
kol-button-link 2.6ms 2.5ms +4%
kol-card 0.9ms 0.9ms +0%
kol-details 5.1ms 5.1ms 0%
kol-drawer 0.9ms 0.9ms +0%
kol-form 1ms 1ms 0%
kol-heading 0.8ms 0.9ms -11.1%
kol-icon 1.3ms 1.3ms +0%
kol-image 0.8ms 0.7ms +14.3% 🔻
kol-input-checkbox 3.8ms 3.5ms +8.6%
kol-input-color 1.7ms 1.6ms +6.3%
kol-input-date 1.5ms 1.5ms 0%
kol-input-email 1.6ms 1.3ms +23.1% 🔻
kol-input-file 3ms 2.9ms +3.4%
kol-input-number 1.3ms 1.4ms -7.1%
kol-input-password 1.4ms 1.3ms +7.7%
kol-input-radio 1.3ms 1.3ms +0%
kol-input-text 1.4ms 1.3ms +7.7%
kol-link 2.4ms 2.3ms +4.3%
kol-link-button 2.4ms 2.4ms +0%
kol-modal 0.9ms 0.8ms +12.5% 🔻
kol-nav 1ms 1ms 0%
kol-pagination 15.8ms 15.7ms +0.6%
kol-popover-button 3.4ms 3.5ms -2.9%
kol-progress 1.1ms 1ms +10%
kol-quote 0.9ms 0.9ms +0%
kol-select 1.7ms 1.5ms +13.3% 🔻
kol-skip-nav 0.8ms 0.8ms +0%
kol-spin 0.9ms 0.8ms +12.5% 🔻
kol-split-button 7.7ms 7.5ms +2.7%
kol-table-stateful 19.2ms 18.8ms +2.1%
kol-table-stateless 17.8ms 16.9ms +5.3%
kol-tabs 1ms 1ms 0%
kol-textarea 1.5ms 1.4ms +7.1%
kol-toolbar 1.1ms 1.1ms +0%
kol-tree 1.4ms 1.7ms -17.6%
kol-tree-item 3.6ms 3.5ms +2.9%
kol-version 5.4ms 5.4ms 0%

@anicyne anicyne requested a review from sdvg June 2, 2025 14:55
deleonio and others added 4 commits June 2, 2025 18:46
…radio-hitbox

* 'develop' of github.com:public-ui/kolibri: (26 commits)
  chore: update benchmark-baseline.json [ci skip]
  chore: release 3.0.0
  refactor: remove all preset `_value` values
  Update range E2E tests
  Add missing type export
  Update tests and snapshots
  Adjust types for kol-select
  Update all snapshots$ $ Refs: #7767
  Adjust types for kol-input-date
  Adjust types for kol-input-range
  Revert state types for min, max and number
  Add E2E tests for kol-input-number
  Fix onChange type
  Update Jest snapshots
  Fix linting/type errors in adjacent components
  Update all snapshots$ $ Refs: #7767
  Normalize kol-input-number type to be number, allow NumberString as input
  Normalize kol-input-number type to be number, allow NumberString as input
  inputs-get-value sample: Save values in local state (bound inputs)
  Attempt to fix upload-reports
  ...
Comment thread packages/components/src/components/input-radio/shadow.tsx Outdated
@anicyne anicyne force-pushed the 7303-fix-radio-hitbox branch from 77996b6 to d74c4b6 Compare June 5, 2025 14:38
@anicyne anicyne requested a review from sdvg June 5, 2025 14:46
Comment thread packages/components/src/components/input-radio/shadow.tsx Outdated
@anicyne anicyne requested a review from sdvg June 6, 2025 12:29
@sdvg sdvg requested a review from deleonio June 11, 2025 06:57
@deleonio deleonio merged commit 85a024e into develop Jun 11, 2025
11 checks passed
@deleonio deleonio deleted the 7303-fix-radio-hitbox branch June 11, 2025 09:44
@publicuibot publicuibot bot locked and limited conversation to collaborators Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DESY - Input Radio

3 participants